[WIP] Add privacy filter for mobile/small screens #4510
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
/update-vrt |
|
Thank you for the PR! If I remember correctly, this feature was intentionally left out for mobile because users can just simply move their phones to avoid unwanted glances. Maybe other users can chime in if this would provide value for them but if we are to add this in, we need a way to make it easier to toggle the privacy filter on all the mobile pages e.g. transactions page, accounts, etc. |
|
My one concern is that its hard to view the data when privacy mode is on, and in some cases its probably impossible currently to view the numbers on mobile. It could be cool if we had like a "shake to enable" privacy mode or something that could be done quickly and on any page. |
|
Thank you both for the reviews/comments My use case is fairly niche in that I was trying to quickly demo to someone but didn't want to show my actual figures or set up a dummy budget - then thought it would be useful to have feature parity between mobile/desktop. But I completely get that there may be reasons why this isn't needed! To be honest until @youngcw suggested shake to trigger I was about ready to abandon this PR - I don't think there's a consistent space for a toggle button or something across all the pages, and it doesn't seem like an important enough feature to go about redesigning the whole mobile layout... 😆 I'm happy to take a look at if such a trigger is even possible though, it would certainly fix the issue of trying to find a place to put it! Would there be any opposition to the shake opening the menu where I've currently placed the filter option, so then it's a little more extensible if we want to add additional items in the future (e.g. undo last action)? |
|
What about a button somewhere in setting or beside the settings button? Would be nice to have this feature if you ever want to show someone how actual looks and works and stuff. I mean I know there is demo and I could also create a new budget but this would be easier. |
Adds the privacy filter option to the small screen version of the app. Most of the functionality was already there, it was just a case of adding the menu item and removing the explicit exclusion