✨ Memoize external accounts for bank sync

[lelemm]

External accounts are sorted when showing the modal, but the way its coded, its resorting the list every frame.
This PR memoizes the sorted list to resort it only when changing the list

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	010946f
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67c8410075131900084967b0
😎 Deploy Preview	https://deploy-preview-4540.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
18	8.09 MB → 8.1 MB (+8.24 kB)	+0.10%

Changeset

File	Δ	Size
locale/nl.json	📈 +5.34 kB (+5.45%)	97.97 kB → 103.3 kB
locale/en.json	📈 +2.72 kB (+2.62%)	103.78 kB → 106.5 kB
src/components/modals/SelectLinkedAccountsModal.jsx	📈 +173 B (+2.03%)	8.34 kB → 8.51 kB
locale/fr.json	📈 +10 B (+0.01%)	116.48 kB → 116.49 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/nl.js	97.97 kB → 103.3 kB (+5.34 kB)	+5.45%
static/js/en.js	103.78 kB → 106.5 kB (+2.72 kB)	+2.62%
static/js/index.js	5.35 MB → 5.35 MB (+173 B)	+0.00%
static/js/fr.js	116.48 kB → 116.49 kB (+10 B)	+0.01%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/es.js	58.26 kB	0%
static/js/de.js	115.52 kB	0%
static/js/en-GB.js	96.66 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/uk.js	111.06 kB	0%
static/js/pt-BR.js	110.52 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/AppliedFilters.js	10.87 kB	0%
static/js/wide.js	103.22 kB	0%
static/js/narrow.js	88.98 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.83 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.83 MB	0%

[coderabbitai]

Walkthrough

The pull request integrates a new use of the useMemo hook within the SelectLinkedAccountsModal.jsx component to optimize the sorting of externalAccounts. Instead of sorting the original array on every render, a new variable sortedExternalAccounts is created by sorting a copy of externalAccounts based on account names. This change ensures that the sorted list is recalculated only when externalAccounts updates. The references in both the onNext function and the Table component have been updated to use sortedExternalAccounts, and an import for useMemo has been added to the component.

Suggested labels

:sparkles: Merged

Suggested reviewers

• youngcw
• matt-fidd

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84e4cda and 010946f.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/4540.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Visual regression
• GitHub Check: Functional
• GitHub Check: build (windows-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: build (macos-latest)

🔇 Additional comments (4)

packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx (4)

1-1: Updated React import to include useMemo.

The import statement has been correctly updated to include useMemo from React, which is necessary for the memoization implementation.

---

44-48: Excellent optimization with useMemo!

This is a great performance optimization. By memoizing the sorted list of external accounts:

1. You're creating a copy before sorting (preventing mutation of props)
2. You're using localeCompare for proper string comparison
3. The dependency array ensures re-sorting only happens when externalAccounts changes

This effectively addresses the issue mentioned in the PR objectives where sorting was happening on every render.

---

76-78: Updated reference to use memoized accounts list.

Correctly updated the reference in the onNext function to use the memoized sortedExternalAccounts instead of directly accessing and potentially re-sorting externalAccounts.

---

184-184: Updated Table component to use memoized accounts list.

The Table component now uses the memoized and sorted accounts list, ensuring consistent rendering and avoiding redundant sorting operations on every render.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.