Replace usage of deprecated Button in Autocomplete with new Button component #4561

joel-jeremy · 2025-03-06T22:11:56Z

After this PR, we can delete the deprecated Button component 🎉

…mponent

netlify · 2025-03-06T22:12:17Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`744bb4b`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67cb17817abba400086af8a3
😎 Deploy Preview	https://deploy-preview-4561.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-03-06T22:14:11Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
18	8.12 MB → 8.12 MB (+349 B)	+0.00%

Changeset

File	Δ	Size
`src/components/autocomplete/Autocomplete.tsx`	📈 +339 B (+2.04%)	16.27 kB → 16.6 kB
`src/components/autocomplete/PayeeAutocomplete.tsx`	📈 +10 B (+0.07%)	14.91 kB → 14.92 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	5.37 MB → 5.37 MB (+349 B)	+0.01%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/es.js	59.63 kB	0%
static/js/de.js	118.58 kB	0%
static/js/en-GB.js	96.66 kB	0%
static/js/en.js	108.34 kB	0%
static/js/pt-BR.js	110.52 kB	0%
static/js/fr.js	119.06 kB	0%
static/js/nl.js	103.3 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/AppliedFilters.js	10.87 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/uk.js	111.06 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/wide.js	100.26 kB	0%
static/js/narrow.js	88.44 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

github-actions · 2025-03-06T22:14:13Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	2.57 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	2.57 MB	0%

coderabbitai · 2025-03-06T22:15:16Z

Walkthrough

The changes update the autocomplete components in the desktop client. The modifications include refactoring import statements to use a centralized component library for standardized components such as Button, SvgRemove, and theme. In the Autocomplete.tsx component, a new reference (itemsViewRef) is introduced to manage dropdown item interactions by refining the onBlur event logic with conditional checks. The rendering of dropdown items is now wrapped in a View component linked to the new reference for improved focus and interaction management. Similarly, the PayeeAutocomplete.tsx component sees its Button imports and prop usage updated by replacing the type prop with variant and converting onClick to onPress. Additionally, an obsolete onMouseDown event handler is removed.

Possibly related PRs

Replace usage of deprecated Button in TransactionEdit with new Button component #4560: Involves updating the import path for the Button component to a centralized source and modifying its properties from type to variant, as well as changing event handlers from onClick to onPress.
♻️ removing usages of MenuButton #4555: Directly related to the modifications in the main PR, focusing on the Button component's type prop being replaced with variant.
♻️ (typescript) migrated ManagePayees and LoadBackupModal files #3507: Updates the Button component's prop from type to variant and changes the import path, similar to the main PR.

Suggested labels

:sparkles: Merged

Suggested reviewers

lelemm
MikesGlitch

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b15d70a and 744bb4b.

📒 Files selected for processing (1)

packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/desktop-client/src/components/autocomplete/Autocomplete.tsx

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Visual regression
GitHub Check: Functional
GitHub Check: Analyze
GitHub Check: build (ubuntu-latest)
GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (1)
466-468: Remove console.log statements before merging.

These debug statements should be removed before the PR is finalized.
-                  console.log('onBlur', e);
-                  console.log('closeOnBlur', closeOnBlur);
-                  console.log('clearOnBlur', clearOnBlur);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fd5164 and b15d70a.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4561.md is excluded by !**/*.md

📒 Files selected for processing (2)

packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (6 hunks)
packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)
GitHub Check: Wait for Netlify build to finish
GitHub Check: Analyze

🔇 Additional comments (8)

packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (5)

14-15: Good job updating component imports.

The imports have been correctly updated to use the centralized component library, which aligns with the project's goal of standardizing component usage.

Also applies to: 18-18

258-258: Good addition of itemsViewRef.

Adding this ref will help manage the dropdown items view and improve interaction handling.

473-481: Good improvement to blur handling logic.

This change prevents the dropdown from closing when users interact with dropdown items, which improves the user experience.

605-612: Good implementation of dropdown items view.

Wrapping the items in a View component with the itemsViewRef connects the blur handling logic with the rendered items, enabling the improved interaction.

639-639: Correctly updated Button prop from type to variant.

This change aligns with the new Button component API.

packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (3)

16-16: Good job updating Button import.

The import has been correctly updated to use the centralized component library.

451-457: Correctly updated Button props.

The type prop has been changed to variant and onClick to onPress to align with the new Button component API.

462-465: Correctly updated Button props.

The variant and onPress props are correctly used here as well, maintaining consistency across the component.

packages/desktop-client/src/components/autocomplete/Autocomplete.tsx

Replace usage of deprecated Button in Autocomplete with new Button co…

2f70a56

…mponent

actual-github-bot bot changed the title ~~Replace usage of deprecated Button in Autocomplete with new Button component~~ [WIP] Replace usage of deprecated Button in Autocomplete with new Button component Mar 6, 2025

actual-github-bot bot added the 🚧 WIP label Mar 6, 2025

Release notes

b15d70a

joel-jeremy changed the title ~~[WIP] Replace usage of deprecated Button in Autocomplete with new Button component~~ Replace usage of deprecated Button in Autocomplete with new Button component Mar 6, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Mar 6, 2025

coderabbitai bot reviewed Mar 6, 2025

View reviewed changes

lelemm requested changes Mar 7, 2025

View reviewed changes

packages/desktop-client/src/components/autocomplete/Autocomplete.tsx Outdated Show resolved Hide resolved

actual-github-bot bot added ⚠️ Changes requested and removed 🔍 Ready for review labels Mar 7, 2025

Remove console.log

744bb4b

actual-github-bot bot added 🔍 Ready for review and removed ⚠️ Changes requested labels Mar 7, 2025

joel-jeremy requested a review from lelemm March 7, 2025 16:17

lelemm approved these changes Mar 7, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Mar 7, 2025

joel-jeremy merged commit 4bc3477 into master Mar 7, 2025
21 checks passed

joel-jeremy deleted the Autocomplete-rac-button branch March 7, 2025 16:47

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Mar 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace usage of deprecated Button in Autocomplete with new Button component #4561

Replace usage of deprecated Button in Autocomplete with new Button component #4561

joel-jeremy commented Mar 6, 2025

netlify bot commented Mar 6, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025 •

edited

Loading

coderabbitai bot commented Mar 6, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

Replace usage of deprecated Button in Autocomplete with new Button component #4561

Replace usage of deprecated Button in Autocomplete with new Button component #4561

Conversation

joel-jeremy commented Mar 6, 2025

netlify bot commented Mar 6, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Mar 6, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Mar 6, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Mar 6, 2025 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

netlify bot commented Mar 6, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025 •

edited

Loading

coderabbitai bot commented Mar 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)