♻️ (components) rename SimpleTable to InfiniteScrollWrapper and cleanup

[MatissJanis]

1. renamed SimpleTable to InfiniteScrollWrapper to better reflect what it actually does
2. removed some unused functionality from the component

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	ff5e426
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67cc8c2c1446b700088f859e
😎 Deploy Preview	https://deploy-preview-4578.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
18	8.44 MB → 8.44 MB (-473 B)	-0.01%

Changeset

File	Δ	Size
src/components/common/InfiniteScrollWrapper.tsx	🆕 +808 B	0 B → 808 B
src/components/admin/UserDirectory/UserDirectory.tsx	📉 -120 B (-1.18%)	9.92 kB → 9.8 kB
src/components/ManageRules.tsx	📉 -120 B (-1.29%)	9.12 kB → 9 kB
src/components/admin/UserAccess/UserAccess.tsx	📉 -110 B (-1.56%)	6.9 kB → 6.79 kB
src/components/common/SimpleTable.tsx	🔥 -931 B (-100%)	931 B → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/index.js	5.42 MB → 5.42 MB (-473 B)	-0.01%

Unchanged

Asset	File Size	% Changed
static/js/en-GB.js	96.66 kB	0%
static/js/de.js	118.58 kB	0%
static/js/es.js	59.63 kB	0%
static/js/en.js	108.43 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/uk.js	111.06 kB	0%
static/js/fr.js	119.26 kB	0%
static/js/nl.js	103.3 kB	0%
static/js/pt-BR.js	110.52 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/wide.js	100.26 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/AppliedFilters.js	10.87 kB	0%
static/js/narrow.js	368.57 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	2.57 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	2.57 MB	0%

[coderabbitai]

Walkthrough

The changes update several components within the desktop client by replacing the SimpleTable component with the InfiniteScrollWrapper component. In the ManageRules.tsx, UserAccess.tsx, and UserDirectory.tsx files, the table-based UI that previously relied on SimpleTable for loading additional content is now refactored to use an infinite scrolling mechanism via InfiniteScrollWrapper. Alongside the component replacement, import paths for assets like theme, SvgLockOpen, and SvgLockClosed have been updated to reference new absolute paths or locations within the common components. The refactored InfiniteScrollWrapper itself has had its prop types modified, with certain properties and event handlers removed to streamline its functionality. These modifications maintain the existing UI layout while shifting the data rendering approach to support infinite scrolling.

Possibly related PRs

• ♻️ (typescript) migrated ManagePayees and LoadBackupModal files #3507: Involves similar replacements of SimpleTable with InfiniteScrollWrapper in multiple UI components affecting rules, user access, and user directory views.
• Update sidebar scrolling #3554: Implements the component replacement in different contexts, paralleling the modifications observed in the main PR.
• 🧪 improving rules test e2e stability #3512: Mirrors the transition from a paginated table to an infinite scrolling interface in key UI components, aligning closely with the current changes.

Suggested labels

:sparkles: Merged, :white_check_mark: Approved

Suggested reviewers

• joel-jeremy
• youngcw

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42294d4 and ff5e426.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/4578.md is excluded by !**/*.md

📒 Files selected for processing (4)

• packages/desktop-client/src/components/ManageRules.tsx (4 hunks)
• packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx (3 hunks)
• packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx (4 hunks)
• packages/desktop-client/src/components/common/InfiniteScrollWrapper.tsx (3 hunks)

🔇 Additional comments (16)

packages/desktop-client/src/components/ManageRules.tsx (3)

15-15: Good practice using absolute imports.

The import path for theme has been updated to use the absolute path from the component library, which is a good practice for improving maintainability and making import paths more consistent.

---

35-35: Import updated to match component rename.

The import statement correctly reflects the renamed component InfiniteScrollWrapper that replaces the previous SimpleTable component.

---

325-338: Component replacement improves semantic clarity.

The SimpleTable component has been appropriately replaced with InfiniteScrollWrapper, which better describes the component's purpose of providing infinite scrolling functionality. The implementation maintains the same behavior while using a more accurately named component.

packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx (4)

14-15: Icon imports updated to use absolute paths.

The import paths for the SVG icons have been updated to use absolute paths from the component library, which improves maintainability and consistency across the codebase.

---

17-17: Theme import updated for consistency.

The theme import path has been standardized to use the absolute path from the component library.

---

30-30: Import added for renamed component.

The import statement correctly reflects the renamed component InfiniteScrollWrapper.

---

193-199: Component implementation updated for clarity.

The SimpleTable component has been replaced with the more accurately named InfiniteScrollWrapper. This maintains the same infinite scrolling functionality while using a component name that better describes its purpose.

packages/desktop-client/src/components/common/InfiniteScrollWrapper.tsx (6)

1-1: Simplified imports.

The imports have been streamlined by removing unnecessary ones, keeping only what's needed for the component's functionality.

---

5-8: Improved type definition.

The type has been renamed from SimpleTableProps to InfiniteScrollWrapperProps and simplified by removing unused properties, making the component's API cleaner and more focused.

---

10-14: Clearer component documentation.

The component documentation has been updated to accurately describe its purpose as a wrapper for infinitely loading lists, which improves code clarity and maintainability.

---

15-19: Component renamed for clarity.

The component has been renamed from SimpleTable to InfiniteScrollWrapper to better reflect its purpose. The ref handling has also been simplified, removing contentRef and initializing scrollRef with null.

---

40-43: Styling comment updated.

The styling comment has been updated to explain the purpose of the marginBottom: -1 property, which helps future developers understand why this specific styling is applied.

---

52-52: Simplified event handling.

The onMouseLeave event handler has been removed from the div wrapping the children, streamlining the component by removing unused functionality.

packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx (3)

16-16: Theme import path standardized.

The import path for theme has been updated to use the absolute path from the component library, maintaining consistency with the other files in this PR.

---

31-31: Import added for renamed component.

The import statement correctly reflects the renamed component InfiniteScrollWrapper that replaces the previous SimpleTable component.

---

302-314: Component renamed for semantic clarity.

The SimpleTable component has been replaced with InfiniteScrollWrapper, which better reflects its purpose of providing infinite scrolling functionality rather than just displaying a simple table. The implementation maintains the same behavior while using a more accurately named component.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.