Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VCNL4040 / VCNL4020 Lux + Proximity sensor #498

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Sep 28, 2023

@tyeth
Copy link
Contributor Author

tyeth commented Sep 28, 2023

Tested on Feather ESP32v2
Screenshot 2023-09-28 151954

@tyeth
Copy link
Contributor Author

tyeth commented Sep 28, 2023

Ready for review.
Worth noting @brentru there is a related issue in components repo adafruit/Wippersnapper_Components#182

@brentru
Copy link
Member

brentru commented Dec 13, 2023

@tyeth Looking at this, do you want me to review at this point in time?

@tyeth tyeth force-pushed the add-vcnl4040 branch 3 times, most recently from bcc7b7b to 68272ac Compare January 11, 2024 18:24
@tyeth tyeth changed the title Add VCNL4040 Lux + Proximity sensor Add VCNL4040 / VCNL4020 Lux + Proximity sensor Jan 11, 2024
@tyeth
Copy link
Contributor Author

tyeth commented Jan 11, 2024

Screenshot 2024-01-11 212625

@tyeth
Copy link
Contributor Author

tyeth commented Jan 11, 2024

@tyeth Looking at this, do you want me to review at this point in time?

@brentru yes please

@brentru
Copy link
Member

brentru commented Jan 11, 2024

Approved, merging in!

@brentru brentru merged commit 4bf2bbf into adafruit:main Jan 11, 2024
29 checks passed
@tyeth tyeth deleted the add-vcnl4040 branch March 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants