Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vl6180x_arduinoJson6 #532

Closed
wants to merge 6 commits into from
Closed

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Jan 9, 2024

tempororary CI building PR to test arduinoJson v6 + VL6180X

@brentru brentru self-requested a review January 11, 2024 21:38
@@ -36,7 +36,7 @@ jobs:
echo >>$GITHUB_ENV WS_VERSION=$(git describe --dirty --tags)
- uses: actions/checkout@v4
with:
repository: adafruit/ci-arduino
repository: tyeth/ci-arduino
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop build-clang-doxy.yml from this PR, I know why you did it but it matches main now

@@ -5,6 +5,6 @@ maintainer=Adafruit <adafruitio@adafruit.com>
sentence=Arduino application for Adafruit.io WipperSnapper
paragraph=Arduino application for Adafruit.io WipperSnapper
category=Communication
url=https://github.com/adafruit/Adafruit_IO_Arduino
url=https://github.com/adafruit/Adafruit_Wippersnapper_Arduino
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@@ -40,6 +40,24 @@
#include "Wippersnapper_Boards.h"
#include "components/statusLED/Wippersnapper_StatusLED.h"

#define WS_DEBUG ///< Define to enable debugging to serial terminal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these added?

@tyeth tyeth closed this Jan 12, 2024
@tyeth tyeth deleted the vl6180x_arduinoJson6 branch January 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants