Skip to content

Commit 9d7205f

Browse files
adamaverayadamaveray
committed
Merge branch 'main' into feature/automaticKeyboardInsetsImprovements
* main: (135 commits) translation auto-update for i18n/twilight.config.json on master Interop: Introduce Bridge proxy Remove okhttp internal util usage (facebook#37843) Update debian to fix CI while updating Node (facebook#37841) fix: foreground ripple crash on api < 23 (facebook#37901) Re-add the top level LICENSE file (facebook#37916) Deploy 0.209.0 to xplat (facebook#37921) Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914) add emitObjectProp in parser primitives (facebook#37904) Make React-utils its own pod (facebook#37659) feat: allow custom assignment of rootView to rootViewController (facebook#37873) Switch xplat prettier config to hermes plugin (facebook#37915) Set iOS AppState to inactive when app is launching (facebook#37690) Use `fileExists` in replace_hermes script (facebook#37911) (docs): fix license url (facebook#37909) Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+ Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874) Fix component type references in xplat (facebook#37903) Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867) test runtime lifecycle callback (facebook#37897) ...
2 parents 145cc56 + e66c906 commit 9d7205f

File tree

388 files changed

+7457
-3910
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

388 files changed

+7457
-3910
lines changed

‎.circleci/config.yml

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ references:
4747
# -------------------------
4848
dependency_versions:
4949
xcode_version: &xcode_version "14.3.0"
50-
nodelts_image: &nodelts_image "cimg/node:18.12.1"
51-
nodeprevlts_image: &nodeprevlts_image "cimg/node:16.18.1"
50+
nodelts_image: &nodelts_image "cimg/node:20.2.0"
51+
nodeprevlts_image: &nodeprevlts_image "cimg/node:18.12.1"
5252

5353
# -------------------------
5454
# Cache Key Anchors
@@ -60,8 +60,8 @@ references:
6060
gems_cache_key: &gems_cache_key v1-gems-{{ checksum "Gemfile.lock" }}
6161
gradle_cache_key: &gradle_cache_key v1-gradle-{{ checksum "gradle/wrapper/gradle-wrapper.properties" }}-{{ checksum "packages/react-native/ReactAndroid/gradle.properties" }}
6262
hermes_workspace_cache_key: &hermes_workspace_cache_key v5-hermes-{{ .Environment.CIRCLE_JOB }}-{{ checksum "/tmp/hermes/hermesversion" }}
63-
hermes_workspace_debug_cache_key: &hermes_workspace_debug_cache_key v2-hermes-{{ .Environment.CIRCLE_JOB }}-debug-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "/tmp/react-native-version" }}
64-
hermes_workspace_release_cache_key: &hermes_workspace_release_cache_key v2-hermes-{{ .Environment.CIRCLE_JOB }}-release-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "/tmp/react-native-version" }}
63+
hermes_workspace_debug_cache_key: &hermes_workspace_debug_cache_key v2-hermes-{{ .Environment.CIRCLE_JOB }}-debug-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "/tmp/react-native-version" }}-{{ checksum "packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh" }}
64+
hermes_workspace_release_cache_key: &hermes_workspace_release_cache_key v2-hermes-{{ .Environment.CIRCLE_JOB }}-release-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "/tmp/react-native-version" }}-{{ checksum "packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh" }}
6565
hermes_linux_cache_key: &hermes_linux_cache_key v1-hermes-{{ .Environment.CIRCLE_JOB }}-linux-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "/tmp/react-native-version" }}
6666
hermes_windows_cache_key: &hermes_windows_cache_key v2-hermes-{{ .Environment.CIRCLE_JOB }}-windows-{{ checksum "/Users/circleci/project/tmp/hermes/hermesversion" }}-{{ checksum "/tmp/react-native-version" }}
6767
hermes_tarball_debug_cache_key: &hermes_tarball_debug_cache_key v4-hermes-tarball-debug-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "/tmp/react-native-version" }}
@@ -795,7 +795,7 @@ jobs:
795795
name: Create Android template project
796796
command: |
797797
REPO_ROOT=$(pwd)
798-
node ./scripts/set-rn-template-version.js "file:$REPO_ROOT/build/$(cat build/react-native-package-version)"
798+
node ./scripts/update-template-package.js "{\"react-native\":\"file:$REPO_ROOT/build/$(cat build/react-native-package-version)\"}"
799799
node ./scripts/template/initialize.js --reactNativeRootPath $REPO_ROOT --templateName $PROJECT_NAME --templateConfigPath "$REPO_ROOT/packages/react-native" --directory "/tmp/$PROJECT_NAME"
800800
- run:
801801
name: Build the template application for << parameters.flavor >> with Architecture set to << parameters.architecture >>, and using the << parameters.jsengine>> JS engine.
@@ -879,17 +879,13 @@ jobs:
879879
REPO_ROOT=$(pwd)
880880
PACKAGE=$(cat build/react-native-package-version)
881881
PATH_TO_PACKAGE="$REPO_ROOT/build/$PACKAGE"
882-
node ./scripts/set-rn-template-version.js "file:$PATH_TO_PACKAGE"
882+
node ./scripts/update-template-package.js "{\"react-native\":\"file:$PATH_TO_PACKAGE\"}"
883883
node ./scripts/template/initialize.js --reactNativeRootPath $REPO_ROOT --templateName $PROJECT_NAME --templateConfigPath "$REPO_ROOT/packages/react-native" --directory "/tmp/$PROJECT_NAME"
884884
- run:
885885
name: Install iOS dependencies - Configuration << parameters.flavor >>; New Architecture << parameters.architecture >>; JS Engine << parameters.jsengine>>; Flipper << parameters.flipper >>
886886
command: |
887887
cd /tmp/$PROJECT_NAME/ios
888888
889-
if [[ << parameters.flavor >> == "Release" ]]; then
890-
export PRODUCTION=1
891-
fi
892-
893889
if [[ << parameters.architecture >> == "NewArch" ]]; then
894890
export RCT_NEW_ARCH_ENABLED=1
895891
fi
@@ -1132,7 +1128,7 @@ jobs:
11321128
# -------------------------
11331129
prepare_hermes_workspace:
11341130
docker:
1135-
- image: debian:11
1131+
- image: debian:bullseye
11361132
environment:
11371133
- HERMES_WS_DIR: *hermes_workspace_root
11381134
- HERMES_VERSION_FILE: "packages/react-native/sdks/.hermesversion"

‎.flowconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ packages/react-native/flow/
3131

3232
[options]
3333
enums=true
34+
conditional_type=true
3435

3536
emoji=true
3637

@@ -75,4 +76,4 @@ untyped-import
7576
untyped-type-import
7677

7778
[version]
78-
^0.207.0
79+
^0.209.0

‎.flowconfig.android

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ packages/react-native/flow/
3131

3232
[options]
3333
enums=true
34+
conditional_type=true
3435

3536
emoji=true
3637

@@ -75,4 +76,4 @@ untyped-import
7576
untyped-type-import
7677

7778
[version]
78-
^0.207.0
79+
^0.209.0

‎.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ DerivedData
2121
*.xcuserstate
2222
project.xcworkspace
2323
**/.xcode.env.local
24+
/poackages/react-native/sdks/downloads/
2425

2526
# Gradle
2627
/build/

‎.prettierrc

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,15 @@
55
"requirePragma": true,
66
"singleQuote": true,
77
"trailingComma": "all",
8-
"endOfLine": "lf"
8+
"endOfLine": "lf",
9+
"overrides": [
10+
{
11+
"files": [
12+
"*.js"
13+
],
14+
"options": {
15+
"parser": "hermes"
16+
}
17+
}
18+
]
919
}

‎CHANGELOG.md

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,44 @@
11
# Changelog
22

3+
## v0.71.11
4+
5+
### Changed
6+
7+
- Bump CLI to 10.2.4 and Metro to 0.73.10 ([69804c70cb](https://github.com/facebook/react-native/commit/69804c70cb5c1afba934e55d7c4d694450c918f0) by [@kelset](https://github.com/kelset))
8+
9+
#### iOS specific
10+
11+
- Prefer `Content-Location` header in bundle response as JS source URL ([671ea383fe](https://github.com/facebook/react-native/commit/671ea383fe45dd9834a0c0481360de050df7f0c9) by [@robhogan](https://github.com/robhogan))
12+
13+
### Fixed
14+
15+
#### Android specific
16+
17+
- Fixed crash occurring in certain native views when handling keyboard events. ([f7e35d4ef7](https://github.com/facebook/react-native/commit/f7e35d4ef7d68d06fba1439c0aa6d9ed05b58a7f) by [@aleqsio](https://github.com/aleqsio))
18+
- Prevent crash on OnePlus/Oppo devices in runAnimationStep ([f2c05142](https://github.com/facebook/react-native/commit/f2c05142259563b892e593b5a018bdbb6a0cf177) by [@hsource](https://github.com/hsource))
19+
- Revert "fix: border width top/bottom not matching the border radius" to fix border styling issues ([fd8a19d](https://github.com/facebook/react-native/commit/fd8a19d5e2bc00f29b3cd992d24790084cc34cbd) by [@kelset](https://github.com/kelset))
20+
21+
#### iOS specific
22+
23+
- Make 0.71 compatible with Xcode 15 (thanks to @AlexanderEggers for the commit in main) ([5bd1a4256e](https://github.com/facebook/react-native/commit/5bd1a4256e0f55bada2b3c277e1dc8aba67a57ce) by [@kelset](https://github.com/kelset))
24+
25+
## v0.71.10
26+
27+
### Fixed
28+
29+
#### Android specific
30+
31+
- Bump RNGP to 0.71.19 ([3be3a7d1a2](https://github.com/facebook/react-native/commit/3be3a7d1a2840a045892ddd8e5f2263028e15127) by [@kelset](https://github.com/kelset))
32+
- contains: RNGP dependency substitutions for fork with different Maven group ([012e4bd654](https://github.com/facebook/react-native/commit/012e4bd654f1eee2b00a066ba50a7f9c44cc305b) by [@douglowder](https://github.com/douglowder))
33+
34+
## v0.71.9
35+
36+
### Fixed
37+
38+
- VirtualizedList scrollToEnd with no data ([98009ad94b](https://github.com/facebook/react-native/commit/98009ad94b92320307f2721ee39dbeb9152c0a58) by [@Andarius](https://github.com/Andarius))
39+
- Allow string `transform` style in TypeScript ([2558c3d4f5](https://github.com/facebook/react-native/commit/2558c3d4f56776699602b116aff8c22b8bfa176a) by [@NickGerleman](https://github.com/NickGerleman))
40+
- Fix autoComplete type for TextInput ([94356e14ec](https://github.com/facebook/react-native/commit/94356e14ec0562a1fd5a208d93021f102ba9565e) by [@iRoachie](https://github.com/iRoachie))
41+
342
## v0.71.8
443

544
### Fixed
@@ -606,6 +645,22 @@ Read the [announcement blogpost here](https://reactnative.dev/blog/2023/01/12/ve
606645

607646
- Bump terser minor version to mitigate CVE-2022-25858 ([743f9ff63b](https://github.com/facebook/react-native/commit/743f9ff63bf1e3825a1788978a9f6bad8ebddc0d) by [@GijsWeterings](https://github.com/GijsWeterings))
608647

648+
## v0.70.10
649+
650+
### Fixed
651+
652+
#### Android specific
653+
654+
- Prevent crash on OnePlus/Oppo devices in runAnimationStep ([c05d822f7d](https://github.com/facebook/react-native/commit/c05d822f7daa92e8af2ec2cd97a9897425624cc2) by [@hsource](https://github.com/hsource))
655+
656+
#### iOS specific
657+
658+
- USE_HERMES envvar check fixed in react-native-xcode.sh. ([61106ac680](https://github.com/facebook/react-native/commit/61106ac6805cddef97e16e473b155abdad701797)) by [@kidroca](https://github.com/kidroca))
659+
- USE_HERMES envvar check fixed in react-native-xcode.sh. Now source maps are generated by default. ([8ad63714](https://github.com/facebook/react-native/commit/8ad63714ed3070aa9fdf95b702d89ef8fb423d9d)) by [@dmytrorykun](https://github.com/dmytrorykun))
660+
- USE_HERMES envvar check fixed in react-native-xcode.sh. ([4108b3](https://github.com/facebook/react-native/commit/4108b374385f1ede69e82ca0f8ca6d6585aee8c4)) by [@dmytrorykun](https://github.com/dmytrorykun))
661+
- When source maps are enabled, clean up temporary files from the build directory. Reduces bundle size by at least 1MB. ([bad3949](https://github.com/facebook/react-native/commit/bad39493b976b425fdf72cd8cf1543a375d612ab)) by [@dmytrorykun](https://github.com/dmytrorykun))
662+
- Make 0.70 compatible with Xcode 15 (thanks to @AlexanderEggers for the commit in main) ([c5e549e694](https://github.com/facebook/react-native/commit/c5e549e694607cd576be8fcb5ed909fec2ed6dce))
663+
609664
## v0.70.9
610665

611666
### Changed
@@ -953,6 +1008,14 @@ Read the [announcement blogpost here](https://reactnative.dev/blog/2023/01/12/ve
9531008
- Add GitHub token permissions for workflows ([3da3d82320](https://github.com/facebook/react-native/commit/3da3d82320bd035c6bd361a82ea12a70dba4e851) by [@varunsh-coder](https://github.com/varunsh-coder))
9541009
- Bump RCT-Folly to 2021-07-22 ([68f3a42fc7](https://github.com/facebook/react-native/commit/68f3a42fc7380051714253f43b42175de361f8bd) by [@luissantana](https://github.com/luissantana))
9551010

1011+
## v0.69.11
1012+
1013+
### Fixed
1014+
1015+
#### iOS specific
1016+
1017+
- Make 0.69 compatible with Xcode 15 (thanks to @AlexanderEggers for the commit in main) ([37e8df1cdc](https://github.com/facebook/react-native/commit/37e8df1cdce4a66763c720b1b0768d049def9518))
1018+
9561019
## v0.69.10
9571020

9581021
### Fixed

‎LICENSE

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
MIT License
2+
3+
Copyright (c) Meta Platforms, Inc. and affiliates.
4+
5+
Permission is hereby granted, free of charge, to any person obtaining a copy
6+
of this software and associated documentation files (the "Software"), to deal
7+
in the Software without restriction, including without limitation the rights
8+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9+
copies of the Software, and to permit persons to whom the Software is
10+
furnished to do so, subject to the following conditions:
11+
12+
The above copyright notice and this permission notice shall be included in all
13+
copies or substantial portions of the Software.
14+
15+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21+
SOFTWARE.

‎README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,5 +143,5 @@ React Native is MIT licensed, as found in the [LICENSE][l] file.
143143

144144
React Native documentation is Creative Commons licensed, as found in the [LICENSE-docs][ld] file.
145145

146-
[l]: https://github.com/facebook/react-native/blob/HEAD/LICENSE
147-
[ld]: https://github.com/facebook/react-native/blob/HEAD/LICENSE-docs
146+
[l]: https://github.com/facebook/react-native/blob/main/LICENSE
147+
[ld]: https://github.com/facebook/react-native/blob/main/LICENSE-docs

‎jest/preprocessor.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,10 @@ module.exports = {
8989
);
9090
},
9191

92-
getCacheKey: (createCacheKeyFunction([
92+
// $FlowFixMe[signature-verification-failure]
93+
getCacheKey: createCacheKeyFunction([
9394
__filename,
9495
require.resolve('metro-react-native-babel-transformer'),
9596
require.resolve('@babel/core/package.json'),
96-
]) /*: any */),
97+
]),
9798
};

‎package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"eslint-plugin-react-native": "^4.0.0",
7979
"eslint-plugin-redundant-undefined": "^0.4.0",
8080
"eslint-plugin-relay": "^1.8.3",
81-
"flow-bin": "^0.207.0",
81+
"flow-bin": "^0.209.0",
8282
"hermes-eslint": "0.12.0",
8383
"inquirer": "^7.1.0",
8484
"jest": "^29.2.1",
@@ -90,6 +90,7 @@
9090
"mkdirp": "^0.5.1",
9191
"mock-fs": "^5.1.4",
9292
"prettier": "2.8.8",
93+
"prettier-plugin-hermes-parser": "0.12.1",
9394
"react": "18.2.0",
9495
"react-test-renderer": "18.2.0",
9596
"shelljs": "^0.8.5",

‎packages/react-native-codegen/e2e/__tests__/modules/__snapshots__/GenerateModuleH-test.js.snap

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ struct Bridging<NativeEnumTurboModuleStatusRegularEnum> {
206206
}
207207
}
208208

209-
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusRegularEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
209+
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusRegularEnum value) {
210210
if (value == NativeEnumTurboModuleStatusRegularEnum::Active) {
211211
return bridging::toJs(rt, \\"Active\\");
212212
} else if (value == NativeEnumTurboModuleStatusRegularEnum::Paused) {
@@ -238,7 +238,7 @@ struct Bridging<NativeEnumTurboModuleStatusStrEnum> {
238238
}
239239
}
240240

241-
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusStrEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
241+
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusStrEnum value) {
242242
if (value == NativeEnumTurboModuleStatusStrEnum::Active) {
243243
return bridging::toJs(rt, \\"active\\");
244244
} else if (value == NativeEnumTurboModuleStatusStrEnum::Paused) {
@@ -270,7 +270,7 @@ struct Bridging<NativeEnumTurboModuleStatusNumEnum> {
270270
}
271271
}
272272

273-
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusNumEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
273+
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusNumEnum value) {
274274
if (value == NativeEnumTurboModuleStatusNumEnum::Active) {
275275
return bridging::toJs(rt, 2);
276276
} else if (value == NativeEnumTurboModuleStatusNumEnum::Paused) {
@@ -302,7 +302,7 @@ struct Bridging<NativeEnumTurboModuleStatusFractionEnum> {
302302
}
303303
}
304304

305-
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusFractionEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
305+
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusFractionEnum value) {
306306
if (value == NativeEnumTurboModuleStatusFractionEnum::Active) {
307307
return bridging::toJs(rt, 0.2f);
308308
} else if (value == NativeEnumTurboModuleStatusFractionEnum::Paused) {
@@ -2149,7 +2149,7 @@ struct Bridging<NativeEnumTurboModuleStatusRegularEnum> {
21492149
}
21502150
}
21512151

2152-
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusRegularEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
2152+
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusRegularEnum value) {
21532153
if (value == NativeEnumTurboModuleStatusRegularEnum::Active) {
21542154
return bridging::toJs(rt, \\"Active\\");
21552155
} else if (value == NativeEnumTurboModuleStatusRegularEnum::Paused) {
@@ -2181,7 +2181,7 @@ struct Bridging<NativeEnumTurboModuleStatusStrEnum> {
21812181
}
21822182
}
21832183

2184-
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusStrEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
2184+
static jsi::String toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusStrEnum value) {
21852185
if (value == NativeEnumTurboModuleStatusStrEnum::Active) {
21862186
return bridging::toJs(rt, \\"active\\");
21872187
} else if (value == NativeEnumTurboModuleStatusStrEnum::Paused) {
@@ -2213,7 +2213,7 @@ struct Bridging<NativeEnumTurboModuleStatusNumEnum> {
22132213
}
22142214
}
22152215

2216-
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusNumEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
2216+
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusNumEnum value) {
22172217
if (value == NativeEnumTurboModuleStatusNumEnum::Active) {
22182218
return bridging::toJs(rt, 2);
22192219
} else if (value == NativeEnumTurboModuleStatusNumEnum::Paused) {
@@ -2245,7 +2245,7 @@ struct Bridging<NativeEnumTurboModuleStatusFractionEnum> {
22452245
}
22462246
}
22472247

2248-
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusFractionEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
2248+
static jsi::Value toJs(jsi::Runtime &rt, NativeEnumTurboModuleStatusFractionEnum value) {
22492249
if (value == NativeEnumTurboModuleStatusFractionEnum::Active) {
22502250
return bridging::toJs(rt, 0.2f);
22512251
} else if (value == NativeEnumTurboModuleStatusFractionEnum::Paused) {

‎packages/react-native-codegen/src/generators/modules/GenerateModuleH.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ struct Bridging<${enumName}> {
343343
${fromCases}
344344
}
345345
346-
static ${toValue} toJs(jsi::Runtime &rt, ${enumName} value, const std::shared_ptr<CallInvoker> &jsInvoker) {
346+
static ${toValue} toJs(jsi::Runtime &rt, ${enumName} value) {
347347
${toCases}
348348
}
349349
};`;

‎packages/react-native-codegen/src/generators/modules/__tests__/__snapshots__/GenerateModuleH-test.js.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ struct Bridging<SampleTurboModuleCxxNumEnum> {
222222
}
223223
}
224224

225-
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleCxxNumEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
225+
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleCxxNumEnum value) {
226226
if (value == SampleTurboModuleCxxNumEnum::ONE) {
227227
return bridging::toJs(rt, 1);
228228
} else if (value == SampleTurboModuleCxxNumEnum::TWO) {
@@ -252,7 +252,7 @@ struct Bridging<SampleTurboModuleCxxFloatEnum> {
252252
}
253253
}
254254

255-
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleCxxFloatEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
255+
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleCxxFloatEnum value) {
256256
if (value == SampleTurboModuleCxxFloatEnum::POINT_ZERO) {
257257
return bridging::toJs(rt, 0.0f);
258258
} else if (value == SampleTurboModuleCxxFloatEnum::POINT_ONE) {
@@ -282,7 +282,7 @@ struct Bridging<SampleTurboModuleCxxStringEnum> {
282282
}
283283
}
284284

285-
static jsi::String toJs(jsi::Runtime &rt, SampleTurboModuleCxxStringEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
285+
static jsi::String toJs(jsi::Runtime &rt, SampleTurboModuleCxxStringEnum value) {
286286
if (value == SampleTurboModuleCxxStringEnum::HELLO) {
287287
return bridging::toJs(rt, \\"hello\\");
288288
} else if (value == SampleTurboModuleCxxStringEnum::GoodBye) {
@@ -1220,7 +1220,7 @@ struct Bridging<SampleTurboModuleNumEnum> {
12201220
}
12211221
}
12221222

1223-
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleNumEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
1223+
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleNumEnum value) {
12241224
if (value == SampleTurboModuleNumEnum::ONE) {
12251225
return bridging::toJs(rt, 1);
12261226
} else if (value == SampleTurboModuleNumEnum::TWO) {
@@ -1250,7 +1250,7 @@ struct Bridging<SampleTurboModuleFloatEnum> {
12501250
}
12511251
}
12521252

1253-
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleFloatEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
1253+
static jsi::Value toJs(jsi::Runtime &rt, SampleTurboModuleFloatEnum value) {
12541254
if (value == SampleTurboModuleFloatEnum::POINT_ZERO) {
12551255
return bridging::toJs(rt, 0.0f);
12561256
} else if (value == SampleTurboModuleFloatEnum::POINT_ONE) {
@@ -1280,7 +1280,7 @@ struct Bridging<SampleTurboModuleStringEnum> {
12801280
}
12811281
}
12821282

1283-
static jsi::String toJs(jsi::Runtime &rt, SampleTurboModuleStringEnum value, const std::shared_ptr<CallInvoker> &jsInvoker) {
1283+
static jsi::String toJs(jsi::Runtime &rt, SampleTurboModuleStringEnum value) {
12841284
if (value == SampleTurboModuleStringEnum::HELLO) {
12851285
return bridging::toJs(rt, \\"hello\\");
12861286
} else if (value == SampleTurboModuleStringEnum::GoodBye) {

0 commit comments

Comments
 (0)