Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Remove WatchdogPlugin.getInstance() #102

Open
adamk33n3r opened this issue Oct 21, 2023 · 0 comments
Open

[Chore] Remove WatchdogPlugin.getInstance() #102

adamk33n3r opened this issue Oct 21, 2023 · 0 comments
Assignees

Comments

@adamk33n3r
Copy link
Owner

This makes things harder to test. It should be injected everywhere it's needed. And really, most of the time it's just used as a central repository for things I don't want to have to inject like gson, the config, etc. It was nice to iterate fast, but as this codebase is becoming more mature, adding tests would be nice and it's a PITA when nested code is just calling this.

@adamk33n3r adamk33n3r self-assigned this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant