Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification queueing QOL #66

Open
JLeavell opened this issue May 10, 2023 · 3 comments
Open

Notification queueing QOL #66

JLeavell opened this issue May 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@JLeavell
Copy link
Contributor

Currently any event that occur back to back (eg 2 drops over a threshold) and whilst using the capture groups, it will notify of both over top of each other. Debounce will make it so that only one will play (the first one), whereas the ideal behavior would be for them to be one following the other. Possible to add a toggle to make all events of a given notification enter a queue where they play out in order

@adamk33n3r adamk33n3r added the enhancement New feature or request label May 13, 2023
@CreativeTechGuy
Copy link
Contributor

I always thought that the notifications in the list were in order. So the notifications that appeared lower/later in the list would override the notifications higher up if multiple matched. If this feature gets added, it might be worth adding an option that instead of queueing, you can set a notification to override another.

@adamk33n3r
Copy link
Owner

I always thought that the notifications in the list were in order. So the notifications that appeared lower/later in the list would override the notifications higher up if multiple matched. If this feature gets added, it might be worth adding an option that instead of queueing, you can set a notification to override another.

This seems like a new/separate feature request. The original issue describes queueing the same alert being fired quickly. Your suggestion is about comparing multiple different alerts. Or rather, processing alerts in a set order and stopping once one fires successfully. You can create a new issue for this if you want, but I will say that this would require a massive overhaul if you'd be wanting to override alerts of other types. Probably wouldn't be tooo bad if we only want to do "the first one that matches" of a specific type.

@CreativeTechGuy
Copy link
Contributor

Ah sorry I misunderstood the original issue. You are right, it's separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants