Skip to content

Commit 90720d7

Browse files
test: add data-test-id for inputs
1 parent 92d1bb3 commit 90720d7

File tree

11 files changed

+33
-0
lines changed

11 files changed

+33
-0
lines changed

packages/form/src/input/Checkbox.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,15 @@ export interface CheckboxProps extends RefProp<HTMLInputElement> {
7878
* cutom checkbox checked icon
7979
*/
8080
iconChecked?: string;
81+
82+
name?: string;
8183
}
8284

8385
export const Checkbox = ({
8486
ref,
8587
label,
8688
value,
89+
name,
8790
checked,
8891
invalid,
8992
disabled,
@@ -92,6 +95,7 @@ export const Checkbox = ({
9295
icon,
9396
iconChecked,
9497
onChange,
98+
...rest
9599
}: CheckboxProps) => {
96100
const [actualValue, setActualValue] = useState(false);
97101
const deferred = useDeferredValue(!!checked);
@@ -137,9 +141,11 @@ export const Checkbox = ({
137141
ref={ref}
138142
size={1}
139143
tabIndex={0}
144+
name={name}
140145
autoComplete="off"
141146
checked={actualValue}
142147
onChange={handleChange}
148+
{...rest}
143149
/>
144150
<Icon
145151
className={classNames(

packages/form/src/input/File.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ export const FileInput = ({
5858
placeholder,
5959
autoFocus,
6060
error,
61+
name,
6162
multiple,
6263
onChange,
6364
onEnterPressed,
@@ -155,6 +156,8 @@ export const FileInput = ({
155156
size={1}
156157
type="file"
157158
multiple={multiple}
159+
data-test-id={name}
160+
name={name}
158161
ref={ref}
159162
autoComplete="off"
160163
{...{ autoFocus }}

packages/form/src/input/Input.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ export const Input = ({
101101
placeholder={placeholder}
102102
disabled={disabled}
103103
readOnly={readOnly}
104+
data-test-id={name}
104105
name={name}
105106
size={1}
106107
type={type}

packages/form/src/input/Number.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ export const Number = ({
6161
required,
6262
placeholder,
6363
autoFocus,
64+
name,
6465
min,
6566
max,
6667
step,
@@ -109,6 +110,8 @@ export const Number = ({
109110
placeholder={placeholder}
110111
disabled={disabled}
111112
readOnly={readOnly}
113+
data-test-id={name}
114+
name={name}
112115
type="number"
113116
size={1}
114117
min={min}

packages/form/src/input/Password.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ export interface PasswordProps extends InputProps, RefProp<HTMLInputElement> {
5151
export const Password = ({
5252
ref,
5353
value,
54+
name,
5455
strength,
5556
invalid,
5657
readOnly,
@@ -124,6 +125,8 @@ export const Password = ({
124125
placeholder={placeholder}
125126
disabled={disabled}
126127
readOnly={readOnly}
128+
data-test-id={name}
129+
name={name}
127130
size={1}
128131
type={show ? "text" : "password"}
129132
ref={ref}

packages/form/src/input/Radio.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export const Radio = ({
8181
icon,
8282
iconChecked,
8383
onChange,
84+
...rest
8485
}: RadioProps) => {
8586
const iconOn = useMemo(
8687
() => iconChecked ?? icon ?? CoreIcons.radioOn,
@@ -120,6 +121,7 @@ export const Radio = ({
120121
value={value}
121122
autoComplete="off"
122123
onChange={handleChange}
124+
{...rest}
123125
/>
124126
<Icon
125127
className={classNames(

packages/form/src/input/Search.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ export interface SearchProps extends InputProps, RefProp<HTMLInputElement> {
5555
export const Search = ({
5656
ref,
5757
value,
58+
name,
5859
invalid,
5960
readOnly,
6061
disabled,
@@ -143,6 +144,8 @@ export const Search = ({
143144
disabled={disabled}
144145
readOnly={readOnly}
145146
size={1}
147+
data-test-id={name}
148+
name={name}
146149
type="search"
147150
ref={ref}
148151
autoComplete="off"

packages/form/src/input/Switch.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ export interface SwitchProps extends RefProp<HTMLInputElement> {
7676
* cutom Switch icon
7777
*/
7878
defaultColor?: ColorType;
79+
80+
name?: string;
7981
}
8082

8183
export const Switch = ({
@@ -87,8 +89,10 @@ export const Switch = ({
8789
error,
8890
width,
8991
color,
92+
name,
9093
defaultColor,
9194
onChange,
95+
...rest
9296
}: SwitchProps) => {
9397
const [actualValue, setActualValue] = useState(false);
9498
const deferred = useDeferredValue(!!checked);
@@ -144,6 +148,7 @@ export const Switch = ({
144148
autoComplete="off"
145149
checked={actualValue}
146150
onChange={handleChange}
151+
{...rest}
147152
/>
148153
<span
149154
aria-hidden="true"

packages/form/src/input/Textarea.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ export interface TextareaProps
5353
export const Textarea = ({
5454
ref,
5555
value,
56+
name,
5657
invalid,
5758
readOnly,
5859
disabled,
@@ -117,6 +118,8 @@ export const Textarea = ({
117118
disabled={disabled}
118119
readOnly={readOnly}
119120
rows={fixedRows}
121+
data-test-id={name}
122+
name={name}
120123
ref={ref}
121124
autoComplete="off"
122125
{...{ autoFocus }}

packages/form/src/select/List.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,8 @@ export const List = <T extends AnyObject = string>({
247247
disabled={disabled}
248248
value={state.query}
249249
aria-invalid={invalid}
250+
data-test-id={name}
251+
name={name}
250252
className={classNames(
251253
"appearance-none bg-transparent outline-none border-none ring-0 flex-1 min-w-24",
252254
disabled && "cursor-not-allowed pointer-events-none",

packages/form/src/select/Select.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,8 @@ export const Select = <T extends AnyObject = string>({
272272
disabled={disabled}
273273
value={state.query}
274274
aria-invalid={invalid}
275+
data-test-id={name}
276+
name={name}
275277
className={classNames(
276278
"appearance-none bg-transparent outline-none border-none ring-0 flex-1 min-w-24",
277279
disabled && "cursor-not-allowed pointer-events-none",

0 commit comments

Comments
 (0)