Merge pull request #1211 from open-dynaMIX/fix_healthz

fix(healthz): do not rely on SAGW email set on identity

Author: open-dynaMIX

api/mysagw/healthz/health_checks.py

@@ -34,7 +34,7 @@ def _check_pending_migrations(db_name):
 def _check_models(database):
     """Check model fetching on database."""
     # Retrieve object
-    identity = Identity.objects.get(email="sagw@sagw.ch", is_organisation=True)
+    identity = Identity.objects.first()
     assert identity
 
     return {database: {"ok": True}}

api/mysagw/healthz/tests/test_healthz.py

@@ -4,12 +4,6 @@
 from watchman import settings as watchman_settings
 
 
-def _set_identity_healthcheck_properties(identity):
-    identity.email = "sagw@sagw.ch"
-    identity.is_organisation = True
-    identity.save()
-
-
 @pytest.mark.parametrize(
     "client,expected_status",
     [
@@ -20,8 +14,6 @@ def _set_identity_healthcheck_properties(identity):
     indirect=["client"],
 )
 def test_healthz_permissions(db, snapshot, identity, client, expected_status):
-    _set_identity_healthcheck_properties(identity)
-
     url = reverse("healthz")
 
     response = client.get(url)
@@ -48,8 +40,6 @@ def test_db_migrations_not_applied(
     Affects database migrations health check, which should detect unapplied
     migrations and fail.
     """
-    _set_identity_healthcheck_properties(identity)
-
     # get /healthz/ response and compare to previous snapshot
     response = client.get(reverse("healthz"))
     snapshot.assert_match(response.json())

api/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "mysagw"
-version = "0.2.0"
+version = "0.2.1"
 description = "Application management for SAGW"
 repository = "https://github.com/adfinis/mySAGW"
 authors = ["Adfinis"]

compose.yaml

@@ -1,5 +1,5 @@
 ---
-x-version: 0.5.2
+x-version: 0.5.3
 
 services:
   db:
@@ -11,7 +11,7 @@ services:
       - "5432:5432"
 
   api:
-    image: ghcr.io/adfinis/mysagw/api:0.2.0
+    image: ghcr.io/adfinis/mysagw/api:0.2.1
     environment:
       - DATABASE_HOST=db
       - DATABASE_PORT=5432