Merge pull request #775 from derrabauke/fix-auth-stuff

fix(auth): improve invalid session handling

Author: derrabauke

app/adapters/application.js

@@ -16,10 +16,23 @@ import OIDCJSONAPIAdapter from "ember-simple-auth-oidc/adapters/oidc-json-api-ad
  */
 export default class ApplicationAdapter extends OIDCJSONAPIAdapter {
   @service session;
+  @service router;
 
   namespace = "api/v1";
 
   get headers() {
     return { ...this.session.headers };
   }
+
+  handleResponse(status, ...args) {
+    if (status === 401) {
+      if (this.session.isAuthenticated) {
+        this.session.invalidate();
+      } else {
+        this.router.transitionTo("login");
+      }
+    }
+
+    return super.handleResponse(status, ...args);
+  }
 }

app/components/sy-topnav/template.hbs

@@ -65,7 +65,7 @@
         </LinkTo>
       </li>
       <li class="nav-top-list-item">
-        <a href="#" data-test-logout {{on "click" (optional this.on-logout)}}>
+        <a href="#" data-test-logout {{on "click" (optional @onLogout)}}>
           <FaIcon @icon="power-off" @prefix="fas" />
           Logout
         </a>

app/protected/controller.js

@@ -30,10 +30,11 @@ export default class ProtectedController extends Controller {
    * @public
    */
   @action
-  invalidateSession() {
+  async invalidateSession() {
     this.autostartTour.done = [];
 
-    this.session.invalidate();
+    await this.session.invalidate();
+
     this.router.transitionTo("login");
   }
 

app/protected/template.hbs

@@ -1,7 +1,7 @@
 <main class="page-main">
   {{#if this.loading}}<span class="loader"></span>{{/if}}
   <div class="page-content page-content--scroll">
-    <SyTopnav @on-logout={{this.invalidateSession}} />
+    <SyTopnav @onLogout={{this.invalidateSession}} />
 
     {{outlet}}
   </div>