-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect sorting of distances in CAP weight file with weights_dist option #144
Comments
Thanks for catching that @thurinj, I imagine it's coming from here https://github.com/adjtomo/pysep/blob/master/pysep/utils/cap_sac.py#L100-L102 Might just need a float conversion before sorting. I'll try to get to that asap |
* removed pypi version documentation, moved to adjdocs bump patch version number remove annoying warning log when specfem source does not have origin time * added docstring for recsec taper parameter * fixed sorting issue related to #144 and extended test to cover this function * update changelog
Hopefully I didn't jump the gun by doing the full version release but I think I fixed this in #145, let me know if that looks good on your end! |
Looks all good to me, thanks for the lightning-fast fix ⚡! |
Hi @bch0w ,
Here's a quick unintended behavior I found using the weights_dist option to write the CAP file from pysep:

It seems that it is using string-based sorting and it messes up with the ordering when moving from 10~ to 100~ and 100~ to 1000~ (distance is the second column, in km).
The text was updated successfully, but these errors were encountered: