Skip to content

Update shells with PATCH operation #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastiankb opened this issue May 15, 2025 · 3 comments
Open

Update shells with PATCH operation #455

sebastiankb opened this issue May 15, 2025 · 3 comments

Comments

@sebastiankb
Copy link
Collaborator

What?

It seems, for /shells only supports PUT for updating the content of an existing shell. However, this is not consistent to other API operations such as for /submodels that allows to use PATCH for updating submodel's content

How?

Support PATCH operation for /shells for updating shells content

@sebastiankb
Copy link
Collaborator Author

It seems there is the same situation for the thumbnail API.

@sebbader-sap
Copy link
Contributor

sebbader-sap commented May 16, 2025

If I remember correctly, we didn't add the operation as no requirement or use case was reported from the community. Can you elaborate for what it's needed?
"Only" for symmetry with the Submodel endpoints? Or is there a scenario that could not be covered otherwise?

Shell objects are rather small and restricted in size compared to Submodels (that could contain arbitrarily many attributes). It therefore seemed feasible to send the whole object every time a change is needed.

@sebastiankb
Copy link
Collaborator Author

I think, it is a question of symmetry and consistency since PATCH is allowed, e.g., on submodel and submodel-element level. The argument of the object size would not match to the submodel-element level. There I would also expect relative small objects, but PATCH is supported there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants