Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate V3.0.2 changes #30

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

BirgitBoss
Copy link
Collaborator

@BirgitBoss BirgitBoss commented Jul 16, 2024

fix: Usage of deprecated data spec. template ID in constraints
#29

fix: rename constraints to include -3a- to be conformant to naming convention
#29

new file for constraints (similar to Part 1), constraints are included

  • added note in Annex “Handling of Constraints”: If a constraint is mentioning the id of the Template, then the same constraints shall also be valid for deprecated data specification template IDs

correction if "AAS in Details" was still used to "Specification of the AAS"

removal of mapping to xml, JSON, rdf because explained in Part 1, reformulations in text

@BirgitBoss BirgitBoss requested a review from JoergNeidig July 16, 2024 13:28
@BirgitBoss
Copy link
Collaborator Author

Hi @JoergNeidig these are the changes that I think are needed for V3.0.2. They would be integrated into the Word-Document for V3.0.2 of Part 3a. Please review. Thank you, Birgit

the ID of the Template,
then the same constraints shall
also be valid for deprecated data specification
 template IDs.

Added category "renamed" in change log for constraints
+ added change in Annex
Copy link

@JoergNeidig JoergNeidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes, but please review the comments made.

@BirgitBoss BirgitBoss merged commit c73c844 into IDTA-01003-a-3-1_working Jul 18, 2024
Copy link

@JoergNeidig JoergNeidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating the requested changes/comments. I agree with the v3.0.2 update.

@BirgitBoss BirgitBoss deleted the BiBo/Update_V3.0.1 branch July 26, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants