Skip to content

Refactor DigitalFile and PreviewFile: SMC => SME File. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jh-isw
Copy link

@jh-isw jh-isw commented Nov 22, 2023

Change the SubmodelElements "DigitalFile" and "PreviewFile" to be of SubmodelElement File instead of SubmodelElementCollection, according to the PDF specification.

Fixes #40

@sirea-07
Copy link

The fix might go into the wrong direction. I think the "DigitalFile" should be of type "SubmodelElementCollection" and one element of it would be the "File" type. Otherwise how can you add the elements optional number of files (0173-1#02-ABI003#001) and document path (0173-1#02-ABI005#001) which are also described in the PDF specification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template not according to specification
2 participants