Skip to content

Commit

Permalink
Fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
saville committed Feb 14, 2024
1 parent 373a6c2 commit fb23b79
Showing 1 changed file with 20 additions and 5 deletions.
25 changes: 20 additions & 5 deletions tests/test_loggers.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,36 @@ def fixture_override_colors():


@pytest.mark.parametrize(
"debug, no_color, disable_timestamps, log_level, fmt",
"debug, no_color, disable_timestamps, log_level, console_format, file_format",
[
(
False,
False,
False,
logging.INFO,
"%(log_color)s%(asctime)s %(levelname)-8s %(message)s",
"%(log_color)s%(asctime)s %(levelname)-8s %(message)s",
),
(
True,
True,
True,
logging.DEBUG,
"%(log_color)s%(levelname)-8s %(message)s",
"%(log_color)s%(asctime)s %(levelname)-8s %(message)s",
),
(True, True, True, logging.DEBUG, "%(log_color)s%(levelname)-8s %(message)s"),
],
)
@mock.patch("buildrunner.loggers.logging")
def test_initialize_root_logger(
logging_mock, debug, no_color, disable_timestamps, log_level, fmt, tmp_path
logging_mock,
debug,
no_color,
disable_timestamps,
log_level,
console_format,
file_format,
tmp_path,
):
logging_mock.DEBUG = logging.DEBUG
logging_mock.INFO = logging.INFO
Expand Down Expand Up @@ -71,11 +86,11 @@ def test_initialize_root_logger(

# Check formatters
file_formatter = file_handler.setFormatter.call_args.args[0]
assert file_formatter.fmt == fmt
assert file_formatter.fmt == file_format
assert file_formatter.no_color
assert file_formatter.color == "white"
stream_formatter = stream_handler.setFormatter.call_args.args[0]
assert stream_formatter.fmt == fmt
assert stream_formatter.fmt == console_format
assert stream_formatter.no_color == no_color
assert stream_formatter.color == "white"
# Make sure the formatters are not the same, they should be distinct
Expand Down

0 comments on commit fb23b79

Please sign in to comment.