Add buildx builder support to get_ssh_agent_image #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesliverx
reviewed
Aug 27, 2024
| @@ -0,0 +1,19 @@ | |||
| # Please note that for the SSH unit tests to pass on a local machine, the private key needs to be placed in ~/.ssh/buildrunner-deploy-id_rsa | |||
| # Look in the .github/workflows/build.yaml file for the SSH private key | |||
| use-legacy-builder: False | |||
There was a problem hiding this comment.
random, but False is pythonic, but false is "more correct" for YAML (though both work I believe).
There was a problem hiding this comment.
Good to know. I wasn't aware that YAML had a preference. False definitely works here.
bluesliverx
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Previous Behavior
New Behavior
Merge requirements satisfied?
setup.py(if appropriate).