-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog-template design #460
Blog-template design #460
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional things to change:
- hide the back button, it currently still appears
- let's try to reformat the date in the author box to read January 29th, 2024 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/DateTimeFormat can help with that
Co-authored-by: Lars Trieloff <lars@trieloff.net>
Co-authored-by: Lars Trieloff <lars@trieloff.net>
@trieloff , for the back button, I left it as is since we have to link it to main blog page too.. shall I still remove it for the time being? |
I initially didn't find the https://github.com/asthabh23 link which is behind the GitHub logo. To me that logo implies a link to GitHub itself, I didn't expect it to link to the author's page. How about linking from the author's picture and name instead? That would be more obvious to me. I also suggest adding an |
Thanks @bdelacretaz for your inputs! I have added author name to author's picture. Regarding Github profile for author, we have the logo explicitly, adding link to the image or name might not be intuitive... |
Description
This PR consists of design for blog-template layout.
Related Issue
This is a new feature or section to be introduced in helix website
Motivation and Context
This is the start point to setup the base layout for public facing blogs around Edge Delivery Services. The blog template can be used to create blogs that will cover details around the specific topics of Edge Delivery Services, related screenshots (as required) along with the author details who would be creating the blog.
Types of changes
Checklist:
https://main--helix-website--adobe.aem.page/drafts/asthabharga/blog
vs
https://blog-template--helix-website--adobe.aem.page/drafts/asthabharga/blog
This PR addresses issue #458