Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog-template design #460

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Blog-template design #460

merged 9 commits into from
Feb 2, 2024

Conversation

asthabh23
Copy link
Member

@asthabh23 asthabh23 commented Jan 31, 2024

Description

This PR consists of design for blog-template layout.

Related Issue

This is a new feature or section to be introduced in helix website

Motivation and Context

This is the start point to setup the base layout for public facing blogs around Edge Delivery Services. The blog template can be used to create blogs that will cover details around the specific topics of Edge Delivery Services, related screenshots (as required) along with the author details who would be creating the blog.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

https://main--helix-website--adobe.aem.page/drafts/asthabharga/blog
vs
https://blog-template--helix-website--adobe.aem.page/drafts/asthabharga/blog

This PR addresses issue #458

Copy link

aem-code-sync bot commented Jan 31, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 31, 2024

Page Scores Audits Google
/drafts/asthabharga/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@asthabh23 asthabh23 requested a review from trieloff January 31, 2024 11:31
@asthabh23 asthabh23 linked an issue Jan 31, 2024 that may be closed by this pull request
Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional things to change:

Co-authored-by: Lars Trieloff <lars@trieloff.net>
Co-authored-by: Lars Trieloff <lars@trieloff.net>
@asthabh23
Copy link
Member Author

Additional things to change:

@trieloff , for the back button, I left it as is since we have to link it to main blog page too.. shall I still remove it for the time being?
Regarding date, I will update the logic 👍🏻, unable to proceed at the moment due to the hlx cli issue as it is unable to sync with this branch.

@bdelacretaz
Copy link
Contributor

I initially didn't find the https://github.com/asthabh23 link which is behind the GitHub logo. To me that logo implies a link to GitHub itself, I didn't expect it to link to the author's page.

How about linking from the author's picture and name instead? That would be more obvious to me.

I also suggest adding an alt attribute to the author's picture, with the author name.

@asthabh23
Copy link
Member Author

I initially didn't find the https://github.com/asthabh23 link which is behind the GitHub logo. To me that logo implies a link to GitHub itself, I didn't expect it to link to the author's page.

How about linking from the author's picture and name instead? That would be more obvious to me.

I also suggest adding an alt attribute to the author's picture, with the author name.

Thanks @bdelacretaz for your inputs! I have added author name to author's picture.

Regarding Github profile for author, we have the logo explicitly, adding link to the image or name might not be intuitive...
@trieloff wdyt?

@asthabh23 asthabh23 merged commit 3e21880 into main Feb 2, 2024
3 checks passed
@asthabh23 asthabh23 deleted the blog-template branch February 2, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content template design for blog posts
3 participants