Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecation banner #486

Merged
merged 3 commits into from
Mar 19, 2024
Merged

feat: deprecation banner #486

merged 3 commits into from
Mar 19, 2024

Conversation

rofe
Copy link
Contributor

@rofe rofe commented Mar 18, 2024

@rofe rofe requested a review from davidnuescheler March 18, 2024 19:04
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 18, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 18, 2024 •
edited
Loading

Page Scores Audits Google
/developer/forms PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to deprecation-banner March 18, 2024 19:14 Inactive
@dylandepass dylandepass self-requested a review March 18, 2024 19:14
@dylandepass
Copy link
Member

dylandepass commented Mar 18, 2024 •
edited
Loading

@rofe What about something a bit more in your face?

like
Screenshot 2024-03-18 at 3 15 21 PM

#d31510

davidnuescheler
davidnuescheler approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@davidnuescheler davidnuescheler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@rofe rofe merged commit 7d1288a into main Mar 19, 2024
4 checks passed
@rofe rofe deleted the deprecation-banner branch March 19, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandepass dylandepass dylandepass approved these changes

@davidnuescheler davidnuescheler davidnuescheler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rofe @dylandepass @davidnuescheler