Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Labs titles #488

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Custom Labs titles #488

merged 4 commits into from
Mar 26, 2024

Conversation

trieloff
Copy link
Contributor

See https://custom-labs--helix-website--adobe.aem.page/docs/generate-variations

  • feat(labs): allow custom labs headers
  • fix(labs): better brand new styling

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 22, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 22, 2024 •
edited
Loading

Page Scores Audits Google
/docs/generate-variations PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@trieloff trieloff requested a review from rofe March 25, 2024 09:08
rofe
rofe approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@rofe rofe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would .trim() the parts

@trieloff trieloff merged commit 03717da into main Mar 26, 2024
4 checks passed
@trieloff trieloff deleted the custom-labs branch March 26, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rofe rofe rofe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trieloff @rofe