Skip to content

Commit 25d09d6

Browse files
committed
Convert component tests to integration tests. Don't test internals anymore
1 parent d33d2c2 commit 25d09d6

File tree

7 files changed

+13305
-5055
lines changed

7 files changed

+13305
-5055
lines changed

.template-lintrc.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
'use strict';
22

33
module.exports = {
4-
extends: 'recommended'
4+
extends: 'recommended',
5+
rules: {
6+
'block-indentation': "tab"
7+
}
58
};

addon/components/ember-chart.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,12 @@ import Component from '@ember/component';
44
export default Component.extend({
55
tagName: 'canvas',
66
attributeBindings: ['width', 'height'],
7-
plugins: [],
7+
8+
init() {
9+
this._super(...arguments);
10+
11+
this.plugins = this.plugins || [];
12+
},
813

914
didInsertElement() {
1015
this._super(...arguments);
@@ -38,7 +43,7 @@ export default Component.extend({
3843
let data = this.get('data');
3944
let options = this.get('options');
4045
let animate = this.get('animate');
41-
46+
4247
if (chart) {
4348
chart.data = data;
4449
chart.options = options;

0 commit comments

Comments
 (0)