Skip to content

Commit 33d8253

Browse files
committed
Merge remote-tracking branch 'origin/version3'
2 parents 67a0a2f + 986fc90 commit 33d8253

File tree

6 files changed

+12
-11
lines changed

6 files changed

+12
-11
lines changed

addon/components/ember-chart.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Ember from 'ember';
2-
/* global Chart */
2+
import Chart from 'npm:chart.js';
33

44
export default Ember.Component.extend({
55
tagName: 'canvas',

app/components/ember-chart.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
import EmberChart from 'ember-cli-chart/components/ember-chart';
2+
import Chart from 'npm:chart.js';
23

34
export default EmberChart;

blueprints/ember-cli-chart/index.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
1+
const RSVP = require('rsvp');
2+
13
module.exports = {
24
normalizeEntityName: function() {},
35

46
afterInstall: function() {
5-
return this.addBowerPackageToProject('chartjs', '2.1.1');
7+
return RSVP.all([
8+
this.addPackageToProject('chart.js', '2.2.1'),
9+
this.addAddonToProject('ember-browserify')
10+
]);
611
}
712
};

bower.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"ember": "~2.5.0",
55
"ember-cli-shims": "0.1.1",
66
"ember-cli-test-loader": "0.2.2",
7-
"ember-qunit-notifications": "0.1.0",
8-
"chartjs": "2.1.1"
7+
"ember-qunit-notifications": "0.1.0"
98
}
109
}

index.js

+1-7
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,5 @@
22
'use strict';
33

44
module.exports = {
5-
name: 'ember-cli-chart',
6-
7-
included: function included(app) {
8-
this._super.included(app);
9-
10-
app.import(app.bowerDirectory + '/chartjs/dist/Chart.js');
11-
}
5+
name: 'ember-cli-chart'
126
};

package.json

+2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@
2929
"homepage": "https://github.com/aomran/ember-cli-chart",
3030
"devDependencies": {
3131
"broccoli-asset-rev": "^2.4.2",
32+
"chart.js": "^2.2.1",
3233
"ember-ajax": "0.7.1",
34+
"ember-browserify": "1.1.11",
3335
"ember-cli": "2.5.0",
3436
"ember-cli-app-version": "^1.0.0",
3537
"ember-cli-dependency-checker": "^1.2.0",

0 commit comments

Comments
 (0)