Skip to content

Commit 8d5acbb

Browse files
committed
upgrade ember-cli --to 3.11.0
1 parent 5e2ebc7 commit 8d5acbb

12 files changed

+128
-128
lines changed

.eslintrc.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module.exports = {
22
root: true,
33
parserOptions: {
4-
ecmaVersion: 2017,
4+
ecmaVersion: 2018,
55
sourceType: 'module'
66
},
77
plugins: [
@@ -36,8 +36,7 @@ module.exports = {
3636
'tests/dummy/app/**'
3737
],
3838
parserOptions: {
39-
sourceType: 'script',
40-
ecmaVersion: 2015
39+
sourceType: 'script'
4140
},
4241
env: {
4342
browser: false,

.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
/node_modules/
1010

1111
# misc
12+
/.env*
13+
/.pnp*
1214
/.sass-cache
1315
/connect.lock
1416
/coverage/

.npmignore

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
/.bowerrc
1010
/.editorconfig
1111
/.ember-cli
12+
/.env*
1213
/.eslintignore
1314
/.eslintrc.js
1415
/.gitignore
@@ -17,6 +18,7 @@
1718
/.watchmanconfig
1819
/bower.json
1920
/config/ember-try.js
21+
/CONTRIBUTING.md
2022
/ember-cli-build.js
2123
/testem.js
2224
/tests/

.travis.yml

+10-8
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ language: node_js
33
node_js:
44
# we recommend testing addons with the same minimum supported node version as Ember CLI
55
# so that your addon works for all apps
6-
- "6"
6+
- "8"
77

88
sudo: false
99
dist: trusty
@@ -20,10 +20,17 @@ env:
2020
# See https://git.io/vdao3 for details.
2121
- JOBS=1
2222

23+
branches:
24+
only:
25+
- master
26+
# npm version tags
27+
- /^v\d+\.\d+\.\d+/
28+
2329
jobs:
2430
fail_fast: true
2531
allow_failures:
2632
- env: EMBER_TRY_SCENARIO=ember-canary
33+
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
2734

2835
include:
2936
# runs linting and tests with current locked deps
@@ -38,17 +45,12 @@ jobs:
3845
# we recommend new addons test the current and previous LTS
3946
# as well as latest stable release (bonus points to beta/canary)
4047
- stage: "Additional Tests"
41-
env: EMBER_TRY_SCENARIO=ember-lts-2.16
42-
- env: EMBER_TRY_SCENARIO=ember-lts-2.18
48+
env: EMBER_TRY_SCENARIO=ember-lts-3.4
49+
- env: EMBER_TRY_SCENARIO=ember-lts-3.8
4350
- env: EMBER_TRY_SCENARIO=ember-release
4451
- env: EMBER_TRY_SCENARIO=ember-beta
4552
- env: EMBER_TRY_SCENARIO=ember-canary
4653
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
4754

48-
before_install:
49-
- npm config set spin false
50-
- npm install -g npm@4
51-
- npm --version
52-
5355
script:
5456
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO

CONTRIBUTING.md

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# How To Contribute
2+
3+
## Installation
4+
5+
* `git clone <repository-url>`
6+
* `cd my-addon`
7+
* `npm install`
8+
9+
## Linting
10+
11+
* `npm run lint:hbs`
12+
* `npm run lint:js`
13+
* `npm run lint:js -- --fix`
14+
15+
## Running tests
16+
17+
* `ember test` – Runs the test suite on the current Ember version
18+
* `ember test --server` – Runs the test suite in "watch mode"
19+
* `ember try:each` – Runs the test suite against multiple Ember versions
20+
21+
## Running the dummy application
22+
23+
* `ember serve`
24+
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
25+
26+
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

LICENSE

-21
This file was deleted.

LICENSE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) 2018
3+
Copyright (c) 2019
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
66

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
[![Build Status](https://travis-ci.org/aomran/ember-cli-chart.svg)](https://travis-ci.org/aomran/ember-cli-chart)
44

5-
This Ember CLI addon is a simple wrapper for [ChartJS](http://www.chartjs.org/) (v2.7.0).
5+
This Ember CLI addon is a simple wrapper for [ChartJS](http://www.chartjs.org/) (v2.8.0).
66

77
### Installation
88

config/ember-try.js

+60-70
Original file line numberDiff line numberDiff line change
@@ -2,82 +2,72 @@
22

33
const getChannelURL = require('ember-source-channel-url');
44

5-
module.exports = function() {
6-
return Promise.all([
7-
getChannelURL('release'),
8-
getChannelURL('beta'),
9-
getChannelURL('canary')
10-
]).then((urls) => {
11-
return {
12-
scenarios: [
13-
{
14-
name: 'ember-lts-2.16',
15-
env: {
16-
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
17-
},
18-
npm: {
19-
devDependencies: {
20-
'@ember/jquery': '^0.5.1',
21-
'ember-source': '~2.16.0'
22-
}
5+
module.exports = async function() {
6+
return {
7+
scenarios: [
8+
{
9+
name: 'ember-lts-3.4',
10+
npm: {
11+
devDependencies: {
12+
'ember-source': '~3.4.0'
2313
}
24-
},
25-
{
26-
name: 'ember-lts-2.18',
27-
env: {
28-
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
29-
},
30-
npm: {
31-
devDependencies: {
32-
'@ember/jquery': '^0.5.1',
33-
'ember-source': '~2.18.0'
34-
}
35-
}
36-
},
37-
{
38-
name: 'ember-release',
39-
npm: {
40-
devDependencies: {
41-
'ember-source': urls[0]
42-
}
14+
}
15+
},
16+
{
17+
name: 'ember-lts-3.8',
18+
npm: {
19+
devDependencies: {
20+
'ember-source': '~3.8.0'
4321
}
44-
},
45-
{
46-
name: 'ember-beta',
47-
npm: {
48-
devDependencies: {
49-
'ember-source': urls[1]
50-
}
22+
}
23+
},
24+
{
25+
name: 'ember-release',
26+
npm: {
27+
devDependencies: {
28+
'ember-source': await getChannelURL('release')
5129
}
52-
},
53-
{
54-
name: 'ember-canary',
55-
npm: {
56-
devDependencies: {
57-
'ember-source': urls[2]
58-
}
30+
}
31+
},
32+
{
33+
name: 'ember-beta',
34+
npm: {
35+
devDependencies: {
36+
'ember-source': await getChannelURL('beta')
5937
}
60-
},
61-
{
62-
name: 'ember-default',
63-
npm: {
64-
devDependencies: {}
38+
}
39+
},
40+
{
41+
name: 'ember-canary',
42+
npm: {
43+
devDependencies: {
44+
'ember-source': await getChannelURL('canary')
6545
}
46+
}
47+
},
48+
// The default `.travis.yml` runs this scenario via `npm test`,
49+
// not via `ember try`. It's still included here so that running
50+
// `ember try:each` manually or from a customized CI config will run it
51+
// along with all the other scenarios.
52+
{
53+
name: 'ember-default',
54+
npm: {
55+
devDependencies: {}
56+
}
57+
},
58+
{
59+
name: 'ember-default-with-jquery',
60+
env: {
61+
EMBER_OPTIONAL_FEATURES: JSON.stringify({
62+
'jquery-integration': true
63+
})
6664
},
67-
{
68-
name: 'ember-default-with-jquery',
69-
env: {
70-
EMBER_OPTIONAL_FEATURES: JSON.stringify({
71-
'jquery-integration': true
72-
})
73-
},
74-
npm: {
75-
devDependencies: {
76-
'@ember/jquery': '^0.5.1'
77-
}
65+
npm: {
66+
devDependencies: {
67+
'@ember/jquery': '^0.5.1'
7868
}
7969
}
80-
]
81-
};
82-
});
70+
}
71+
]
72+
};
8373
};

index.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
/* eslint-env node */
1+
'use strict';
2+
23
const FastbootTransform = require('fastboot-transform');
34

45
module.exports = {
5-
name: 'ember-cli-chart',
6+
name: require('./package').name,
67
options: {
78
nodeAssets: {
89
'chart.js': {

package.json

+20-21
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
},
1313
"dependencies": {
1414
"chart.js": "^2.8.0",
15-
"ember-cli-babel": "^6.6.0",
15+
"ember-cli-babel": "^7.7.3",
1616
"ember-cli-node-assets": "^0.2.2",
1717
"fastboot-transform": "^0.1.2"
1818
},
@@ -34,35 +34,34 @@
3434
},
3535
"homepage": "https://github.com/aomran/ember-cli-chart",
3636
"devDependencies": {
37-
"broccoli-asset-rev": "^2.4.5",
38-
"ember-ajax": "^3.0.0",
39-
"ember-cli": "~2.16.2",
40-
"ember-cli-dependency-checker": "^2.0.0",
41-
"ember-cli-eslint": "^4.0.0",
42-
"ember-cli-htmlbars": "^2.0.1",
43-
"ember-cli-htmlbars-inline-precompile": "^1.0.0",
44-
"ember-cli-inject-live-reload": "^1.4.1",
45-
"ember-cli-qunit": "^4.4.0",
46-
"ember-cli-shims": "^1.1.0",
47-
"ember-cli-sri": "^2.1.0",
48-
"ember-cli-uglify": "^2.0.0",
49-
"ember-disable-prototype-extensions": "^1.1.2",
37+
"@ember/optional-features": "^0.7.0",
38+
"broccoli-asset-rev": "^3.0.0",
39+
"ember-cli": "~3.11.0",
40+
"ember-cli-dependency-checker": "^3.1.0",
41+
"ember-cli-eslint": "^5.1.0",
42+
"ember-cli-htmlbars": "^3.0.1",
43+
"ember-cli-htmlbars-inline-precompile": "^2.1.0",
44+
"ember-cli-inject-live-reload": "^1.8.2",
45+
"ember-cli-sri": "^2.1.1",
46+
"ember-cli-template-lint": "^1.0.0-beta.1",
47+
"ember-cli-uglify": "^2.1.0",
48+
"ember-disable-prototype-extensions": "^1.1.3",
5049
"ember-export-application-global": "^2.0.0",
51-
"ember-load-initializers": "^1.1.0",
50+
"ember-load-initializers": "^2.0.0",
5251
"ember-maybe-import-regenerator": "^0.1.6",
53-
"ember-qunit": "^3.4.1",
52+
"ember-qunit": "^4.4.1",
5453
"ember-resolver": "^5.0.1",
55-
"ember-source": "~3.5.1",
54+
"ember-source": "~3.11.1",
5655
"ember-source-channel-url": "^1.1.0",
5756
"ember-try": "^1.0.0",
5857
"ember-welcome-page": "^3.0.0",
59-
"eslint-plugin-ember": "^5.2.0",
60-
"eslint-plugin-node": "^7.0.1",
58+
"eslint-plugin-ember": "^6.2.0",
59+
"eslint-plugin-node": "^9.0.1",
6160
"loader.js": "^4.7.0",
62-
"qunit-dom": "^0.8.0"
61+
"qunit-dom": "^0.8.4"
6362
},
6463
"engines": {
65-
"node": "6.* || 8.* || >= 10.*"
64+
"node": "8.* || >= 10.*"
6665
},
6766
"ember-addon": {
6867
"configPath": "tests/dummy/config"

tests/dummy/config/environment.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module.exports = function(environment) {
99
EmberENV: {
1010
FEATURES: {
1111
// Here you can enable experimental features on an ember canary build
12-
// e.g. 'with-controller': true
12+
// e.g. EMBER_NATIVE_DECORATOR_SUPPORT: true
1313
},
1414
EXTEND_PROTOTYPES: {
1515
// Prevent Ember Data from overriding Date.parse.

0 commit comments

Comments
 (0)