Skip to content

Commit 17823b2

Browse files
Bump ember versions (#48)
* run ember-cli-update * Use ember-modules-codemod * regenerate lock file * Fix some upgrade issues * Fix test container styles * Fix failing tests due to no PhantomJS
1 parent cc657e8 commit 17823b2

30 files changed

+1674
-1231
lines changed

.bowerrc

-4
This file was deleted.

.eslintrc.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module.exports = {
22
root: true,
33
parserOptions: {
4-
ecmaVersion: 6,
4+
ecmaVersion: 2017,
55
sourceType: 'module'
66
},
77
extends: 'eslint:recommended',

.gitignore

+6
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,11 @@
1414
/coverage/*
1515
/libpeerconnection.log
1616
npm-debug.log*
17+
yarn-error.log
1718
testem.log
1819
.DS_Store
20+
21+
# ember-try
22+
.node_modules.ember-try/
23+
bower.json.ember-try
24+
package.json.ember-try

.npmignore

+5
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,8 @@ bower.json
1515
ember-cli-build.js
1616
testem.js
1717
**/.DS_Store
18+
19+
# ember-try
20+
.node_modules.ember-try/
21+
bower.json.ember-try
22+
package.json.ember-try

.travis.yml

+22-14
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,33 @@
11
---
22
language: node_js
33
node_js:
4-
- "6"
4+
# we recommend testing addons with the same minimum supported node version as Ember CLI
5+
# so that your addon works for all apps
6+
- "4"
57

68
sudo: false
9+
dist: trusty
10+
11+
addons:
12+
chrome: stable
713

814
cache:
915
directories:
1016
- $HOME/.npm
1117

1218
env:
13-
# we recommend testing LTS's and latest stable release (bonus points to beta/canary)
14-
- EMBER_TRY_SCENARIO=ember-lts-2.4
15-
- EMBER_TRY_SCENARIO=ember-lts-2.8
16-
- EMBER_TRY_SCENARIO=ember-release
17-
- EMBER_TRY_SCENARIO=ember-beta
18-
- EMBER_TRY_SCENARIO=ember-canary
19-
- EMBER_TRY_SCENARIO=ember-default
19+
global:
20+
# See https://git.io/vdao3 for details.
21+
- JOBS=1
22+
matrix:
23+
# we recommend new addons test the current and previous LTS
24+
# as well as latest stable release (bonus points to beta/canary)
25+
- EMBER_TRY_SCENARIO=ember-lts-2.12
26+
- EMBER_TRY_SCENARIO=ember-lts-2.16
27+
- EMBER_TRY_SCENARIO=ember-release
28+
- EMBER_TRY_SCENARIO=ember-beta
29+
- EMBER_TRY_SCENARIO=ember-canary
30+
- EMBER_TRY_SCENARIO=ember-default
2031

2132
matrix:
2233
fast_finish: true
@@ -25,13 +36,10 @@ matrix:
2536

2637
before_install:
2738
- npm config set spin false
28-
- npm install -g phantomjs-prebuilt
29-
- phantomjs --version
30-
31-
install:
32-
- npm install
39+
- npm install -g npm@4
40+
- npm --version
3341

3442
script:
3543
# Usually, it's ok to finish the test scenario without reverting
3644
# to the addon's original dependency state, skipping "cleanup".
37-
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO test --skip-cleanup
45+
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup

addon/components/credit-card-input.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import Ember from 'ember';
1+
import { once } from '@ember/runloop';
2+
import { observer } from '@ember/object';
23
import InputMaskComponent from 'ember-inputmask/components/input-mask';
34

45
/**
@@ -34,11 +35,11 @@ export default InputMaskComponent.extend({
3435
this._super();
3536
},
3637

37-
_maskShouldChange: Ember.observer('mask', 'cardType', 'separator', function() {
38-
Ember.run.once(this, 'updateMask');
38+
_maskShouldChange: observer('mask', 'cardType', 'separator', function() {
39+
once(this, 'updateMask');
3940
}),
4041

41-
updateCardType: Ember.observer('unmaskedValue', function() {
42+
updateCardType: observer('unmaskedValue', function() {
4243
var unmaskedValue = this.get('unmaskedValue') || '',
4344
cardType;
4445

addon/components/input-mask.js

+17-12
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
/* global Inputmask */
22

3-
import Ember from 'ember';
3+
import { once, debounce } from '@ember/runloop';
4+
5+
import { isPresent } from '@ember/utils';
6+
import { on } from '@ember/object/evented';
7+
import { computed, observer } from '@ember/object';
8+
import TextField from '@ember/component/text-field';
49

510
/**
611
* `{{input-mask}}` component.
@@ -25,7 +30,7 @@ import Ember from 'ember';
2530
* Enable by setting debounce > 0, makes sure to deduplicate calls to update the UI and only deliver the last ui change
2631
*/
2732

28-
export default Ember.TextField.extend({
33+
export default TextField.extend({
2934
mask: '',
3035

3136
showMaskOnFocus: true,
@@ -41,7 +46,7 @@ export default Ember.TextField.extend({
4146

4247
value: 'value',
4348

44-
options: Ember.computed(function() {
49+
options: computed(function() {
4550
return {};
4651
}),
4752

@@ -52,7 +57,7 @@ export default Ember.TextField.extend({
5257
},
5358

5459
// Remove the mask from the input
55-
teardownMask: Ember.on('willDestroyElement', function() {
60+
teardownMask: on('willDestroyElement', function() {
5661
if (this.element.inputmask) {
5762
this.element.inputmask.remove();
5863
}
@@ -79,7 +84,7 @@ export default Ember.TextField.extend({
7984
inputmask.mask(this.element);
8085

8186
// Initialize the unmasked value if it exists
82-
if (Ember.isPresent(this.get('unmaskedValue'))) {
87+
if (isPresent(this.get('unmaskedValue'))) {
8388
this.element.value = this.get('unmaskedValue');
8489
}
8590

@@ -117,7 +122,7 @@ export default Ember.TextField.extend({
117122
this.setMask();
118123
},
119124

120-
_maskShouldChange: Ember.observer('mask',
125+
_maskShouldChange: observer('mask',
121126
'maskPlaceholder',
122127
'showMaskOnFocus',
123128
'showMaskOnHover',
@@ -127,7 +132,7 @@ export default Ember.TextField.extend({
127132
'pattern',
128133
'regex',
129134
function() {
130-
Ember.run.once(this, 'updateMask');
135+
once(this, 'updateMask');
131136
}),
132137

133138
updateVar: function () {
@@ -140,17 +145,17 @@ export default Ember.TextField.extend({
140145
},
141146

142147
// Unmask the value of the field and set the property.
143-
setUnmaskedValue: Ember.observer('value', function() {
148+
setUnmaskedValue: observer('value', function() {
144149
if (this.element && this.element.inputmask) {
145150
this.set('unmaskedValue', this.element.inputmask.unmaskedvalue());
146151
}
147152
}),
148153

149154
// When the unmaskedValue changes, set the value.
150-
setValue: Ember.observer('unmaskedValue', function() {
151-
var debounce = this.get('debounce');
152-
if ( debounce ) {
153-
Ember.run.debounce(this, this.updateVar, debounce);
155+
setValue: observer('unmaskedValue', function() {
156+
let debounceTime = this.get('debounce');
157+
if ( debounceTime ) {
158+
debounce(this, this.updateVar, debounce);
154159
} else {
155160
this.updateVar();
156161
}

addon/components/number-input.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import Ember from 'ember';
1+
import { once } from '@ember/runloop';
2+
import { observer } from '@ember/object';
23
import InputMaskComponent from 'ember-inputmask/components/input-mask';
34

45
/**
@@ -74,7 +75,7 @@ export default InputMaskComponent.extend({
7475
this._super();
7576
},
7677

77-
_maskShouldChange: Ember.observer(
78+
_maskShouldChange: observer(
7879
'mask',
7980
'group',
8081
'decimal',
@@ -88,6 +89,6 @@ export default InputMaskComponent.extend({
8889
'suffix',
8990
'unmaskAsNumber',
9091
function() {
91-
Ember.run.once(this, 'updateMask');
92+
once(this, 'updateMask');
9293
})
9394
});

addon/components/phone-number-input.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import Ember from 'ember';
1+
import { once } from '@ember/runloop';
2+
import { observer } from '@ember/object';
23
import InputMaskComponent from 'ember-inputmask/components/input-mask';
34

45
/**
@@ -26,7 +27,7 @@ export default InputMaskComponent.extend({
2627
this._super();
2728
},
2829

29-
_maskShouldChange: Ember.observer('mask', 'extensions', function() {
30-
Ember.run.once(this, 'updateMask');
30+
_maskShouldChange: observer('mask', 'extensions', function() {
31+
once(this, 'updateMask');
3132
})
3233
});

addon/components/ssn-input.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import Ember from 'ember';
1+
import { once } from '@ember/runloop';
2+
import { observer } from '@ember/object';
23
import InputMaskComponent from 'ember-inputmask/components/input-mask';
34

45
/**
@@ -14,7 +15,7 @@ export default InputMaskComponent.extend({
1415
this._super();
1516
},
1617

17-
_maskShouldChange: Ember.observer('mask', function() {
18-
Ember.run.once(this, 'updateMask');
18+
_maskShouldChange: observer('mask', function() {
19+
once(this, 'updateMask');
1920
})
2021
});

addon/components/zip-code-input.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import Ember from 'ember';
1+
import { once } from '@ember/runloop';
2+
import { observer } from '@ember/object';
23
import InputMaskComponent from 'ember-inputmask/components/input-mask';
34

45
/**
@@ -27,7 +28,7 @@ export default InputMaskComponent.extend({
2728
this._super();
2829
},
2930

30-
_maskShouldChange: Ember.observer('mask', 'fullCode', function() {
31-
Ember.run.once(this, 'updateMask');
31+
_maskShouldChange: observer('mask', 'fullCode', function() {
32+
once(this, 'updateMask');
3233
})
3334
});

config/ember-try.js

+6-20
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,22 @@
11
/* eslint-env node */
22

33
module.exports = {
4+
useYarn: true,
5+
46
scenarios: [
57
{
6-
name: 'ember-lts-2.4',
7-
bower: {
8-
dependencies: {
9-
'ember': 'components/ember#lts-2-4'
10-
},
11-
resolutions: {
12-
'ember': 'lts-2-4'
13-
}
14-
},
8+
name: 'ember-lts-2.12',
159
npm: {
1610
devDependencies: {
17-
'ember-source': null
11+
'ember-source': '~2.12.0'
1812
}
1913
}
2014
},
2115
{
22-
name: 'ember-lts-2.8',
23-
bower: {
24-
dependencies: {
25-
'ember': 'components/ember#lts-2-8'
26-
},
27-
resolutions: {
28-
'ember': 'lts-2-8'
29-
}
30-
},
16+
name: 'ember-lts-2.16',
3117
npm: {
3218
devDependencies: {
33-
'ember-source': null
19+
'ember-source': '~2.16.0'
3420
}
3521
}
3622
},

ember-cli-build.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
/* eslint-env node */
2+
'use strict';
23

34
const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
45

56
module.exports = function(defaults) {
6-
var app = new EmberAddon(defaults, {
7+
let app = new EmberAddon(defaults, {
78
// Add options here
89
});
910

package.json

+19-18
Original file line numberDiff line numberDiff line change
@@ -14,38 +14,39 @@
1414
"repository": "https://github.com/pzuraq/ember-inputmask",
1515
"scripts": {
1616
"build": "ember build",
17-
"start": "ember server",
17+
"start": "ember serve",
1818
"test": "ember try:each"
1919
},
2020
"dependencies": {
21-
"ember-cli-babel": "^5.1.7",
21+
"ember-cli-babel": "^6.6.0",
2222
"ember-cli-node-assets": "^0.2.2",
2323
"fastboot-transform": "^0.1.1",
2424
"inputmask": "3.3.6"
2525
},
2626
"devDependencies": {
2727
"broccoli-asset-rev": "^2.4.5",
28-
"ember-cli": "2.12.1",
29-
"ember-cli-dependency-checker": "^1.3.0",
30-
"ember-cli-eslint": "^3.0.0",
31-
"ember-cli-htmlbars": "^1.1.1",
32-
"ember-cli-htmlbars-inline-precompile": "^0.3.6",
28+
"ember-ajax": "^3.0.0",
29+
"ember-cli": "~2.17.0",
30+
"ember-cli-dependency-checker": "^2.0.0",
31+
"ember-cli-eslint": "^4.2.1",
32+
"ember-cli-htmlbars": "^2.0.1",
33+
"ember-cli-htmlbars-inline-precompile": "^1.0.0",
3334
"ember-cli-inject-live-reload": "^1.4.1",
34-
"ember-cli-qunit": "^3.1.0",
35-
"ember-cli-release": "0.2.9",
36-
"ember-cli-shims": "^1.0.2",
35+
"ember-cli-qunit": "^4.1.1",
36+
"ember-cli-shims": "^1.2.0",
3737
"ember-cli-sri": "^2.1.0",
38-
"ember-cli-uglify": "^1.2.0",
39-
"ember-disable-prototype-extensions": "^1.1.0",
40-
"ember-export-application-global": "^1.0.5",
41-
"ember-load-initializers": "^0.6.0",
42-
"ember-native-dom-helpers": "^0.4.0",
43-
"ember-resolver": "2.0.3",
44-
"ember-source": "~2.12.0",
38+
"ember-cli-uglify": "^2.0.0",
39+
"ember-disable-prototype-extensions": "^1.1.2",
40+
"ember-export-application-global": "^2.0.0",
41+
"ember-load-initializers": "^1.0.0",
42+
"ember-maybe-import-regenerator": "^0.1.6",
43+
"ember-native-dom-helpers": "^0.5.8",
44+
"ember-resolver": "^4.0.0",
45+
"ember-source": "~2.17.0",
4546
"loader.js": "^4.2.3"
4647
},
4748
"engines": {
48-
"node": ">= 4"
49+
"node": "^4.5 || 6.* || >= 7.*"
4950
},
5051
"ember-addon": {
5152
"configPath": "tests/dummy/config"

0 commit comments

Comments
 (0)