Skip to content

Commit 941c700

Browse files
authored
Merge pull request #67 from gilest/fix/package-root
Ensure workspace root is a private unnamed package
2 parents d964dfc + 2884011 commit 941c700

File tree

5 files changed

+9
-14
lines changed

5 files changed

+9
-14
lines changed

.github/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,5 @@ jobs:
4242
- uses: actions/checkout@v4
4343
- uses: wyvox/action-setup-pnpm@v3
4444
- name: Run Tests
45+
run: pnpm test:ember-compat:one ${{ matrix.try-scenario }}
4546
working-directory: test-app
46-
run: pnpm ember try:one ${{ matrix.try-scenario }}

.release-plan.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"reason": "Appears in changelog section :bug: Bug Fix"
1515
}
1616
],
17-
"pkgJSONPath": "./package.json"
17+
"pkgJSONPath": "./ember-set-helper/package.json"
1818
}
1919
},
2020
"description": "## Release (2024-02-08)\n\nember-set-helper 3.0.0 (major)\n\n#### :boom: Breaking Change\n* `ember-set-helper`, `test-app`\n * [#51](https://github.com/adopted-ember-addons/ember-set-helper/pull/51) Convert to v2 addon, plain function with types ([@johanrd](https://github.com/johanrd))\n\n#### :bug: Bug Fix\n* `ember-set-helper`\n * [#55](https://github.com/adopted-ember-addons/ember-set-helper/pull/55) Add template-registry.ts ([@johanrd](https://github.com/johanrd))\n\n#### :house: Internal\n* Other\n * [#61](https://github.com/adopted-ember-addons/ember-set-helper/pull/61) moving to release-plan ([@MelSumner](https://github.com/MelSumner))\n * [#54](https://github.com/adopted-ember-addons/ember-set-helper/pull/54) Create dependabot.yml ([@MelSumner](https://github.com/MelSumner))\n* `test-app`\n * [#53](https://github.com/adopted-ember-addons/ember-set-helper/pull/53) Add a little CI ([@MelSumner](https://github.com/MelSumner))\n\n#### Committers: 2\n- Melanie Sumner ([@MelSumner](https://github.com/MelSumner))\n- [@johanrd](https://github.com/johanrd)\n"

ember-set-helper/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ember-set-helper",
3-
"version": "2.0.1",
3+
"version": "3.0.0",
44
"description": "A better `mut` helper!",
55
"keywords": [
66
"ember-addon"
@@ -46,7 +46,8 @@
4646
"start": "concurrently 'npm:start:*'",
4747
"start:js": "rollup --config --watch --no-watch.clearScreen",
4848
"start:types": "glint --declaration --watch",
49-
"test": "echo 'A v2 addon does not have tests, run tests in test-app'"
49+
"test": "echo 'A v2 addon does not have tests, run tests in test-app'",
50+
"prepare": "pnpm build"
5051
},
5152
"dependencies": {
5253
"@embroider/addon-shim": "^1.8.7",

package.json

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,6 @@
11
{
2-
"name": "ember-set-helper",
3-
"version": "3.0.0",
4-
"description": "A better `mut` helper!",
5-
"keywords": [
6-
"ember-addon"
7-
],
2+
"private": true,
83
"repository": "https://github.com/adopted-ember-addons/ember-set-helper",
9-
"license": "MIT",
10-
"author": "Chris Garrett",
114
"scripts": {
125
"build": "pnpm --filter ember-set-helper build",
136
"lint": "pnpm --filter '*' lint",

test-app/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
"start": "ember serve",
2525
"test": "concurrently \"npm:lint\" \"npm:test:*\" --names \"lint,test:\"",
2626
"test:ember": "ember test",
27-
"test:ember-compat": "ember try:each"
27+
"test:ember-compat": "ember try:each",
28+
"test:ember-compat:one": "ember try:one"
2829
},
2930
"devDependencies": {
3031
"@babel/core": "^7.23.2",
@@ -121,4 +122,4 @@
121122
"ember": {
122123
"edition": "octane"
123124
}
124-
}
125+
}

0 commit comments

Comments
 (0)