Merge pull request #28 from pzuraq/remove-template-transform

[REFACTOR] Remove template transform

Author: pzuraq

README.md

@@ -5,11 +5,11 @@ A better `mut` helper!
 ```hbs
 {{this.greeting}}
 
-<button {{on "click" (set this.greeting "Hello!")}}>
+<button {{on "click" (set this "greeting" "Hello!")}}>
   English
 </button>
 
-<button {{on "click" (fn (set this.greeting) "Hola!")}}>
+<button {{on "click" (fn (set this "greeting") "Hola!")}}>
   Español
 </button>
 ```
@@ -22,7 +22,7 @@ without having to write your own custom action. For simple cases, this is pretty
 handy:
 
 ```hbs
-<button {{on "click" (set this.greeting "Hello!")}}>
+<button {{on "click" (set this "greeting" "Hello!")}}>
   English
 </button>
 ```
@@ -61,7 +61,7 @@ export default class Counter extends Component {
 
 ```hbs
 <!-- usage -->
-<Counter @onClick={{set this.currentCount}} />
+<Counter @onClick={{set this "currentCount"}} />
 ```
 
 This will set the value of `this.currentCount` to whatever value is passed to it
@@ -70,10 +70,10 @@ user clicks the button).
 
 ### Passing a dynamic path
 
-You can pass a path dynamically using the `path` named argument to the helper:
+You can pass a path dynamically using to the helper as well:
 
 ```hbs
-<button {{on "click" (set this "Hello!" path=this.greetingPath)}}>
+<button {{on "click" (set this this.greetingPath "Hello!")}}>
   English
 </button>
 ```
@@ -92,13 +92,13 @@ from [ember-composable-helpers](https://github.com/DockYard/ember-composable-hel
 to first pick the value off of the event, and then pass it to `{{set}}`:
 
 ```hbs
-<input {{on "input" (pick "target.value" (set this.value))}}>
+<input {{on "input" (pick "target.value" (set this "value"))}}>
 ```
 
 ### Differences from `mut`
 
-- No need to call wrap the helper (e.g. `(set this.foo)` === `(fn (mut this.foo))`)
-- Optional last parameter if setting a static value (e.g. `(set this.foo "bar")` === `(fn (mut this.foo) "bar")`)
+- No need to call wrap the helper (e.g. `(set this "foo")` === `(fn (mut this.foo))`)
+- Optional last parameter if setting a static value (e.g. `(set this "foo" "bar")` === `(fn (mut this.foo) "bar")`)
 - Cannot be used as both a getter and setter for the value, only provides a setter
 
 ## Compatibility

addon/helpers/set.js

@@ -2,18 +2,8 @@ import { helper } from '@ember/component/helper';
 import { assert } from '@ember/debug';
 import { set as emberSet } from '@ember/object';
 
-function set(positional, named) {
-  let [target, maybePath, maybeValue] = positional;
-
-  let namedPath = named.path;
-
-  let path;
-
-  if (namedPath !== undefined) {
-    path = maybePath !== undefined && maybePath !== '' ? `${maybePath}.${namedPath}` : namedPath;
-  } else {
-    path = maybePath;
-  }
+function set(positional) {
+  let [target, path, maybeValue] = positional;
 
   assert(
     'you must pass a path to {{set}}. You can pass a path statically, as in `{{set this.foo}}`, or with the path argument dynamically, as in `{{set this path="foo"}}`',

index.js

@@ -2,28 +2,4 @@
 
 module.exports = {
   name: require('./package').name,
-
-  setupPreprocessorRegistry(type, registry) {
-    const plugin = this._buildPlugin();
-
-    plugin.parallelBabel = {
-      requireFile: __filename,
-      buildUsing: '_buildPlugin',
-      params: {}
-    };
-
-    registry.add('htmlbars-ast-plugin', plugin);
-  },
-
-  _buildPlugin() {
-    const SetTransform = require('./lib/set-transform');
-
-    return {
-      name: 'set-transform',
-      plugin: SetTransform,
-      baseDir() {
-        return __dirname;
-      }
-    };
-  }
 };

lib/set-transform.js

@@ -3,7 +3,7 @@
 </div>
 
 <div>
-  <button type="button" {{on "click" (set this.greeting "Hello!")}}>
+  <button type="button" {{on "click" (set this "greeting" "Hello!")}}>
     English
   </button>
 </div>
@@ -14,7 +14,7 @@
   count: {{this.count}}
 </div>
 <div>
-  <Counter @onUpdate={{set this.count}} />
+  <Counter @onUpdate={{set this "count"}} />
 </div>
 
 <hr>

tests/dummy/app/templates/application.hbs

@@ -1 +1 @@
-<Child @onChange={{set @user.name}} />
+<Child @onChange={{set @user "name"}} />

tests/dummy/app/templates/components/parent.hbs

@@ -1,3 +1,3 @@
-<button type="button" {{on "click" (set @parameter 42 path=@path)}}>
+<button type="button" {{on "click" (set @parameter @path 42)}}>
   Update
 </button>

tests/dummy/app/templates/components/update-parameter.hbs

@@ -11,7 +11,7 @@ module('Integration | Helper | set', function(hooks) {
     await render(hbs`
       <span data-test-greeting>{{this.greeting}}</span>
 
-      <button type="button" {{on "click" (set this.greeting "Hello!")}}>
+      <button type="button" {{on "click" (set this "greeting" "Hello!")}}>
         English
       </button>
     `);
@@ -30,7 +30,7 @@ module('Integration | Helper | set', function(hooks) {
       <span data-test-greeting>{{this.person.name}}</span>
 
       {{#let this.person as |person|}}
-        <button type="button" {{on "click" (set person.name "Liz")}}>
+        <button type="button" {{on "click" (set person "name" "Liz")}}>
           Set Name
         </button>
       {{/let}}
@@ -50,7 +50,7 @@ module('Integration | Helper | set', function(hooks) {
       <span data-test-greeting1>{{this.greeting1}}</span>
       <span data-test-greeting2>{{this.greeting2}}</span>
 
-      <button type="button" {{on "click" (set this "Hello!" path=this.path)}}>
+      <button type="button" {{on "click" (set this this.path "Hello!")}}>
         Set Greeting
       </button>
     `);
@@ -75,7 +75,7 @@ module('Integration | Helper | set', function(hooks) {
       <span data-test-greeting1>{{this.obj.greeting1}}</span>
       <span data-test-greeting2>{{this.obj.greeting2}}</span>
 
-      <button type="button" {{on "click" (set this.obj "Hello!" path=this.path)}}>
+      <button type="button" {{on "click" (set this (concat "obj." this.path) "Hello!")}}>
         Set Greeting
       </button>
     `);
@@ -114,7 +114,7 @@ module('Integration | Helper | set', function(hooks) {
   test('it works without a value', async function(assert) {
     await render(hbs`
       <span data-test-count>{{this.count}}</span>
-      <Counter @onUpdate={{set this.count}} />
+      <Counter @onUpdate={{set this "count"}} />
     `);
 
     assert.equal(find('[data-test-count]').textContent.trim(), '');
@@ -143,7 +143,7 @@ module('Integration | Helper | set', function(hooks) {
     await render(hbs`
       <span data-test-greeting>{{this.greeting}}</span>
 
-      <input {{on "input" (pick "target.value" (set this.greeting))}}>
+      <input {{on "input" (pick "target.value" (set this "greeting"))}}>
     `);
 
     assert.equal(find('[data-test-greeting]').textContent.trim(), '');