Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ci.yml to correct folder #64

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Move ci.yml to correct folder #64

merged 4 commits into from
Feb 12, 2024

Conversation

MelSumner
Copy link
Collaborator

If Merged, this PR would place the ci.yml file in the workflows folder.

@MelSumner
Copy link
Collaborator Author

@mansona is this now failing because we moved it to a different folder?

@gilest
Copy link
Contributor

gilest commented Feb 9, 2024

Looked into this and found it's caused by some issues with the monorepo configuration.

I think this caused the previously released package to be from the project root rather than the addon directory.

Fix PR here: #67

Once that's merged we can rebase this one and it should run
(I was experimenting in #66 and got it passing there)

@MelSumner
Copy link
Collaborator Author

@gilest that did it, thank you!

@MelSumner MelSumner merged commit 999d0e2 into main Feb 12, 2024
8 checks passed
@MelSumner MelSumner deleted the melsumner/fix-ci branch February 12, 2024 18:42
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants