-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for realm normalization #1207
Add support for realm normalization #1207
Conversation
|
Hi @thomasdarimont, Thanks for implementing the realm normalization feature. 💯 The local tests passed, and the output looks good. However, the GitHub workflow is failing due to unmet code coverage checks from the JaCoCo plugin. Could you please take a look at this? Alternatively, we can proceed by adding more test cases or exclude them directly |
Thanks @AssahBismarkabah ! I just updated this PR with changes from your branch. |
This is a squash of the commits from multiple repositories: Original PR by sonOfRa: adorsys#818 Adaptations by thomasdarimont: https://github.com/thomasdarimont/keycloak-config-cli/tree/feature/realm-normalization Fixes adorsys#799 Co-authored-by: Simon Levermann <simon.levermann@codecentric.de> Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
4f022fe
to
cb8c8e0
Compare
Hi @thomasdarimont , thanks :)
|
Workaround for CI fails because ubuntu-latest version is 24.04 which doesn't support python 3.7. Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
d47eecc
to
d2c2e83
Compare
Hi @thomasdarimont, I just reran the workflow, and it seems to be successful. I don't know specifically what changed! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@thomasdarimont, could you please approve the pull request? |
This is a squash of the commits from multiple repositories:
Original PR by sonOfRa: #818
Adaptations by thomasdarimont: https://github.com/thomasdarimont/keycloak-config-cli/tree/feature/realm-normalization
Fixes #799
Co-authored-by: Simon Levermann simon.levermann@codecentric.de
Signed-off-by: Thomas Darimont thomas.darimont@googlemail.comWhat this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR