Added Keycloak 23.0.4, using getGroupByPath again and inverted briefRepresentation #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
============================================
- Coverage 95.76% 95.69% -0.07%
+ Complexity 1366 1356 -10
============================================
Files 80 79 -1
Lines 4367 4346 -21
Branches 491 490 -1
============================================
- Hits 4182 4159 -23
- Misses 92 93 +1
- Partials 93 94 +1 ☔ View full report in Codecov by Sentry. |
jonasvoelcker
force-pushed
the
keycloak-23.0.4
branch
2 times, most recently
from
7e56223 to
9d618c1
Compare
|
jonasvoelcker
changed the title
|
@jonasvoelcker thank you for the quick turnaround! |
|
Hi @st3v0rr, this one should be working, could you please try to rerun the failing build? |
jonasvoelcker
force-pushed
the
keycloak-23.0.4
branch
from
9d618c1 to
054f5f3
Compare
|
|
Hi @st3v0rr, any chance to get this merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As Keycloak 23.0.4 inverted the briefRepresentation flag, this needs to fix it.
Which issue this PR fixes: fixes #976
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR