Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event search, payment_intent events, and off_session 3DS #238

Closed
wants to merge 1 commit into from

Conversation

bpcreech
Copy link

A few different small things in this commit:

  1. Add support for querying events by type and creation date.
  2. Produce payment_intent.succeeded and payment_intent.payment_failed events
  3. Add a simulation of a canonical Stripe test card that supports 3D Secure in off_session mode, if the configured properly with a setup_intent beforehand. This includes addition of a test-only _authenticate endpoint for setup_intents similar to the one that already exists for payment_intents.

A few different small things in this commit:

1. Add support for querying events by type and creation date.
2. Produce payment_intent.succeeded and payment_intent.payment_failed events
3. Add a simulation of a canonical Stripe test card that supports 3D Secure in
   off_session mode, if the configured properly with a setup_intent
   beforehand. This includes addition of a test-only _authenticate endpoint
   for setup_intents similar to the one that already exists for
   payment_intents.
Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bpcreech, thanks again for contributing 👍

Before we look into this, could you split these 3 changes into 3 different commits and/or pull requests (that you can open in parallel)? It both eases review and makes debugging / reverting much easier in case of a bug in the future.

@bpcreech
Copy link
Author

Ah when you said you wanted more at once I thought you wanted a giant PR, not simultaneous PRs, got it, makes sense!

I filed #239 which combines just 2 related event things, which are hard to separate because they're tested together. Let me know if that's acceptable.

Will send another for 3DS which is definitely decoupled.

@bpcreech
Copy link
Author

Also #240 for the 3DS part!

@bpcreech bpcreech closed this Oct 25, 2024
@bpcreech
Copy link
Author

also #241 for a tiny thing about refunds!

@adrienverge
Copy link
Owner

Ah when you said you wanted more at once I thought you wanted a giant PR, not simultaneous PRs, got it, makes sense!

Hehe sorry for not being clear!

Indeed, it's easier to track / review / understand in separated PRs, and we can easily test them all together using git merge if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants