Add event querying and payment_intent events #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpcreech
force-pushed
the
feat/events
branch
2 times, most recently
from
d72b293 to
83183b6
Compare
adrienverge
reviewed
Oct 31, 2024
bpcreech
force-pushed
the
feat/events
branch
2 times, most recently
from
692b464 to
cd31935
Compare
These features are technically separate but it's easier to test them together. The Stripe event query API lets us filter by event type and timestamp. Meanwhile payment_intent successes and failures generate events (this is particularly important for sepa_direct_debit which on the real Stripe API is typically pending for days, on the Stripe test API is typically pending for a minute or so, and in localstripe is pending for 0.5 seconds).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These features are technically separate but it's easier to test them together.
The Stripe event query API lets us filter by event type and timestamp.
Meanwhile payment_intent successes and failures generate events (this is particularly important for sepa_direct_debit which on the real Stripe API is typically pending for days, on the Stripe test API is typically pending for a minute or so, and in localstripe is pending for 0.5 seconds).