fix(nova-5): nova's field resolveForDisplay method signature

anstapol · anstapol · commit 32d9354cd5dc · 2025-03-04T07:59:25.000+01:00
diff --git a/composer.json b/composer.json
@@ -67,8 +67,8 @@
     "prefer-stable": true,
     "repositories": [
         {
-            "type": "path",
-            "url": "./tests/Fixtures/nova"
+            "type": "composer",
+            "url": "https://nova.laravel.com"
         }
     ]
 }
diff --git a/src/NovaEditorJsField.php b/src/NovaEditorJsField.php
@@ -40,11 +40,10 @@ public function __construct($name, $attribute = null, ?callable $resolveCallback
     /**
      * Resolve the field's value for display.
      *
-     * @param  string|null  $attribute
      *
      * @throws \Throwable
      */
-    public function resolveForDisplay($resource, $attribute = null)
+    public function resolveForDisplay($resource, ?string $attribute = null): void
     {
         $attribute = $attribute ?? $this->attribute;
         if ($attribute === 'ComputedField') {

Original file line number	Diff line number	Diff line change
`@@ -40,11 +40,10 @@ public function __construct($name, $attribute = null, ?callable $resolveCallback`
`40`	`40`	`/**`
`41`	`41`	`* Resolve the field's value for display.`
`42`	`42`	`*`
`43`		`- * @param string\|null $attribute`
`44`	`43`	`*`
`45`	`44`	`* @throws \Throwable`
`46`	`45`	`*/`
`47`		`- public function resolveForDisplay($resource, $attribute = null)`
	`46`	`+ public function resolveForDisplay($resource, ?string $attribute = null): void`
`48`	`47`	`{`
`49`	`48`	`$attribute = $attribute ?? $this->attribute;`
`50`	`49`	`if ($attribute === 'ComputedField') {`