Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nova 5 support #113

Merged
merged 2 commits into from
Mar 8, 2025
Merged

Nova 5 support #113

merged 2 commits into from
Mar 8, 2025

Conversation

anstapol
Copy link
Contributor

  • Updated illuminate/support and illuminate/events to include support for version ^12.0.
  • Upgraded laravel/nova from ^4.0 to ^5.0.

These changes ensure compatibility with the latest framework versions while maintaining support for previous versions

@anstapol anstapol force-pushed the nova-5 branch 2 times, most recently from d4b85f9 to 58d1747 Compare February 26, 2025 10:34
@anstapol anstapol changed the title Update Composer Dependencies Nova 5 support Feb 26, 2025
@anstapol
Copy link
Contributor Author

anstapol commented Mar 3, 2025

@Woeler anything else you'd like me to add to this?

@Woeler
Copy link
Contributor

Woeler commented Mar 4, 2025

I tested it and ran into that issue. I have nothing else to mention. I am not a maintainer here unfortunately. Have offered multiple times as we rely on this package in a few projects.

@anstapol
Copy link
Contributor Author

anstapol commented Mar 5, 2025

right @Woeler I thought you were a maintainer for some reason 😅

thanks for the feedback anyways!

Copy link
Collaborator

@roelofr roelofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no access to Nova 5, so thank you for verifying these changes @Woeler.

Looks good to me!

@roelofr roelofr merged commit b45f17f into advoor:master Mar 8, 2025
10 checks passed
@Woeler
Copy link
Contributor

Woeler commented Mar 9, 2025

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants