Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict mode? #46

Open
amacneil opened this issue Jul 24, 2021 · 0 comments
Open

Strict mode? #46

amacneil opened this issue Jul 24, 2021 · 0 comments

Comments

@amacneil
Copy link

We have a unit test which passes when using ts-jest and fails when using esbuild-jest. The difference is that esbuild does not enable strict mode ("use strict") by default, whereas tsc does (when alwaysStrict is set to true).

Failing test: foxglove/rosbag#14

Esbuild does not handle this automatically, but supports it via the banner feature: evanw/esbuild#422 (comment)

Would you consider enabling "use strict" by default when alwaysStrict is enabled, to match ts-jest behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant