forked from recyclarr/recyclarr
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from recyclarr:master #45
Open
pull
wants to merge
61
commits into
aelfa:master
Choose a base branch
from
recyclarr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dedicated "Filter" system for YAML configuration that selectively excludes instances with issues such as duplicate, invalid, or split instances. - Greatly improved console output for configuration errors. - Recyclarr is now better about not completely exiting when there's an issue in a single configuration instance. Fixes #396
- Remove integration test projects and fold their tests into Core.Tests and Cli.Tests - Rename Recyclarr.Tests to Recyclarr.Core.Tests - Rename TestLibrary to Core.TestLibrary to clarify ownership - Remove InternalsVisibleTo references for integration tests - Remove unnecessary project references
This addresses a type conflict warning during build.
- Made lots of classes internal & sealed as needed - Removed Cli.TestLibrary project. TestLibrary projects are only useful if they're going to be reusable in other tests. The Cli project is at the bottom of the dependency chain and doesn't need to be reusable.
Implements principle of least privilege
For package vulnerability scanning
Exceptions thrown related to `!secret` and other YAML features now provide more useful error messages. This commit changes ConfigParser to log the inner exception directly instead of the wrapper exception, providing more useful error information.
The entire contents of a file can be used to set the scalar value of a YAML node using the `!file` tag. Fixes #278
Discussions have been disabled in the repo. Support will be provided through Discord. Update docs and issue templates to reflect this change.
- Consolidate docker-compose files into a single file - Remove unnecessary files - Moved docker-related scripts to the scripts directory
- Updated incorrect docker-related information and instructions - Added details about using CSharpier for code formatting
Replace boolean pipeline phase returns with explicit PipelineFlow enum to improve readability and clarify control flow intent. The primary fix addresses incorrect phase execution order by adding `OrderByRegistration()` to ensure phases run in the sequence they were registered. This change fixes an issue where pipelines weren't executing properly due to phase ordering problems. Additional improvements include: - Move warning about invalid custom formats to transaction logging - Make error handling more consistent across pipeline phases - Improve pipeline termination logic for preview and empty scenarios Release notes not updated because this bug was not delivered to a stable release. Fixes #442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )