feat: Add some more config options #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NoxHarmonium
commented
Nov 2, 2020
•
NoxHarmonium
commented
- Add the ability to specify VisibilityTimeout and RawMessageDelivery which closes Add some more configuration options #83 (incorporating work done in the fork https://github.com/venn-city/serverless-sns-sqs-lambda)
- Add a type for the config structure and switch to '.ts' files which moves us closer to closing Port to TypeScript #51
- Add an integration test to make sure that the plugin works with the latest version of serverless
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com>
Support raw message delivery
- Add a prettier config for formatting consistency
- Packaging with serverless ensures that the plugin is still compatible with the current version of Serverless
NoxHarmonium
requested review from
robinMcA,
dbalmain and
danielnixon
and removed request for
robinMcA
Closed
|
I'll hold off on merging this PR until I've tested it in a real world project. I should be able to do that today. |
robinMcA
reviewed
Nov 3, 2020
|
I've now tested visibility timeout in a real world project and its working great. |
robinMcA
approved these changes
Nov 3, 2020
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.