Skip to content

Commit

Permalink
testing macOS build
Browse files Browse the repository at this point in the history
  • Loading branch information
agracio committed Mar 7, 2025
1 parent 1fa27d9 commit acad6c0
Show file tree
Hide file tree
Showing 9 changed files with 30 additions and 79 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,6 @@ workflows:
matrix:
parameters:
# os: ['linux', 'linux-arm', 'macos']
os: ['linux-arm']
os: ['linux', 'linux-arm']
node-version: ['14', '16' ,'18', '20', '22', '23']

2 changes: 1 addition & 1 deletion .github/actions/build-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ runs:
uses: ./.github/actions/setup-env
with:
node: 20
os: ${{ inputs.runs-on }}
os: ${{ inputs.os }}

- name: Get latest Node.js version for v${{ inputs.node }}
id: node-test-version
Expand Down
16 changes: 8 additions & 8 deletions .github/actions/setup-env/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@ runs:
cache: 'npm'
cache-dependency-path: package-lock.json

# - name: Cache node-gyp Linux
# if: runner.os == 'Linux'
# uses: actions/cache@v4
# env:
# cache-name: cache-node-gyp
# with:
# path: ~/.cache/node-gyp
# key: '${{ inputs.os }}-${{ inputs.node}}'
- name: Cache node-gyp Linux
if: runner.os == 'Linux'
uses: actions/cache@v4
env:
cache-name: cache-node-gyp
with:
path: ~/.cache/node-gyp
key: '${{ inputs.os }}-${{ inputs.node}}'

# - name: Cache node-gyp macOs
# if: runner.os == 'macOS'
Expand Down
43 changes: 0 additions & 43 deletions .github/actions/test-windows/action.yml

This file was deleted.

20 changes: 10 additions & 10 deletions .github/workflows/build-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
name: build node-16
steps:
Expand All @@ -34,7 +34,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
name: build node-18
steps:
Expand All @@ -53,7 +53,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
name: build node-20
steps:
Expand All @@ -72,7 +72,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
name: build node-22
steps:
Expand All @@ -90,7 +90,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
name: build node-23
steps:
Expand All @@ -108,7 +108,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
needs: build-16

Expand All @@ -128,7 +128,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
needs: build-18

Expand All @@ -148,7 +148,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
needs: build-20

Expand All @@ -168,7 +168,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
needs: build-22

Expand All @@ -188,7 +188,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022]
os: [windows-2022, macos-15]
runs-on: ${{ matrix.os }}
needs: build-23

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
strategy:
matrix:
# os: [windows-2022, macos-14]
os: [macos-15]
os: [windows-2022, macos-15]
fail-fast: true

name: build node-${{ inputs.build-version }} ${{ matrix.os }}
Expand All @@ -49,7 +49,7 @@ jobs:
strategy:
matrix:
# os: [windows-2022]
os: [macos-13, macos-15]
os: [windows-2022, macos-13, macos-15]
fail-fast: false

name: test ${{ matrix.os }}-node-${{ inputs.build-version }}
Expand Down
17 changes: 5 additions & 12 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,10 @@ jobs:
strategy:
fail-fast: false
matrix:
# os: [macos-13, macos-14, ubuntu-22.04, ubuntu-22.04-arm, windows-2022]
# os: [macos-13, macos-14]
os: [macos-13, macos-15, ubuntu-24.04, ubuntu-24.04-arm]
os: [macos-13, macos-15, ubuntu-24.04, ubuntu-24.04-arm, windows-2022]
# os: [macos-13, macos-15]
# node: [18, 20, 22, 23]
node: [16,18,20,22,23]
node: [18, 20, 22, 23]
steps:

- name: Checkout code
Expand All @@ -104,17 +103,11 @@ jobs:
# run: |
# pip install setuptools

- name: Run .NET 4.5 tests
if: runner.os == 'Windows'
- if: runner.os == 'Windows'
name: Run .NET 4.5 tests
shell: bash
run: node tools/test.js CI

# - if: runner.os == 'Windows'
# name: Run Windows tests
# uses: ./.github/actions/test-windows
# with:
# node: ${{ matrix.node }}

- if: runner.os == 'macOS' || runner.os == 'Linux'
name: "Run .net core tests"
run: node tools/test.js CI
Expand Down
2 changes: 1 addition & 1 deletion lib/edge.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ if (process.env.EDGE_USE_CORECLR && !process.env.EDGE_BOOTSTRAP_DIR && fs.exists
}

process.env.EDGE_NATIVE = edgeNative;
console.log('edgeNative', edgeNative)
//console.log('edgeNative', edgeNative)
edge = require(edgeNative);

exports.func = function(language, options) {
Expand Down
3 changes: 2 additions & 1 deletion tools/install.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,10 @@ if (process.platform === 'win32') {

else {
if(process.platform === 'darwin'){

const nodeVersion = process.versions.node.split(".")[0]
const edjeNative = path.resolve(__dirname, '../lib/native/' + process.platform + '/' + process.arch + '/' + nodeVersion + '/' + 'edge_coreclr.node');
console.log(edjeNative)

if(fs.existsSync(edjeNative)){
spawn('dotnet', ['build', '--configuration', 'Release'], { stdio: 'inherit', cwd: path.resolve(__dirname, '..', 'lib', 'bootstrap') })
.on('close', function() {
Expand Down

0 comments on commit acad6c0

Please sign in to comment.