testing macOS build

.github/actions/build-node/action.yml

@@ -130,8 +130,17 @@ runs:
 
       - name: Upload artifacts
         uses: actions/upload-artifact@v4
-        if: success()
+        if: runner.os == 'Windows' && success()
         with:
-          name: edge-js-${{ inputs.node }}
+          name: win32-edge-js-${{ inputs.node }}
           path: |
             release
+
+      - name: Upload artifacts
+        uses: actions/upload-artifact@v4
+        if: runner.os  == 'macOS' && success()
+        with:
+          name: darwin-edge-js-${{ inputs.node }}
+          path: |
+            release
+

.github/actions/setup-env/action.yml

@@ -19,23 +19,23 @@ runs:
         cache: 'npm'
         cache-dependency-path: package-lock.json
 
-    - name: Cache node-gyp Linux
-      if: runner.os == 'Linux'
-      uses: actions/cache@v4
-      env:
-        cache-name: cache-node-gyp
-      with:
-        path: ~/.cache/node-gyp
-        key: '${{ inputs.os }}-${{ inputs.node}}'
-
-    - name: Cache node-gyp macOs
-      if: runner.os == 'macOS'
-      uses: actions/cache@v4
-      env:
-        cache-name: cache-node-gyp
-      with:
-        path: ~/Library/Caches/node-gyp
-        key: '${{ inputs.os }}-${{ inputs.node}}'
+    # - name: Cache node-gyp Linux
+    #   if: runner.os == 'Linux'
+    #   uses: actions/cache@v4
+    #   env:
+    #     cache-name: cache-node-gyp
+    #   with:
+    #     path: ~/.cache/node-gyp
+    #     key: '${{ inputs.os }}-${{ inputs.node}}'
+
+    # - name: Cache node-gyp macOs
+    #   if: runner.os == 'macOS'
+    #   uses: actions/cache@v4
+    #   env:
+    #     cache-name: cache-node-gyp
+    #   with:
+    #     path: ~/Library/Caches/node-gyp
+    #     key: '${{ inputs.os }}-${{ inputs.node}}'
 
 
     - name: Cache node modules

.github/actions/test-build/action.yml

@@ -13,12 +13,6 @@ runs:
   using: "composite"
   steps:
 
-    - name: Setup env
-      uses: ./.github/actions/setup-env
-      with:
-        node: ${{ inputs.node }}
-        os: ${{ inputs.os }}
-
     - name: Create release folder
       if:  runner.os == 'Windows'
       shell: pwsh
@@ -72,6 +66,12 @@ runs:
             core.error("Error creating release directory")
             core.setFailed(err)
           }
+          
+    - name: Setup env
+      uses: ./.github/actions/setup-env
+      with:
+        node: ${{ inputs.node }}
+        os: ${{ inputs.os }}
 
     - name: Test
       uses: ./.github/actions/test-windows

.github/workflows/build.yml

@@ -14,6 +14,7 @@ on:
         - 20
         - 22
         - 23
+        - 24
 
 env:
   DOTNET_CLI_TELEMETRY_OPTOUT: 1 

.github/workflows/main.yml

@@ -71,7 +71,6 @@ on:
       - '*.sln'
       - '*.vcxproj'
 
-
 env:
   ACTIONS_ALLOW_UNSECURE_COMMANDS: true # required to setup CSC
   DOTNET_CLI_TELEMETRY_OPTOUT: 1 
@@ -104,14 +103,19 @@ jobs:
       #   run: |
       #     pip install setuptools
 
-      - if: runner.os == 'Windows'
-        name: Run Windows tests
-        uses: ./.github/actions/test-windows
-        with:
-          node: ${{ matrix.node }}
+      - name: Run .NET 4.5 tests
+        if:  runner.os == 'Windows'
+        shell: bash
+        run: node tools/test.js CI
+
+      # - if: runner.os == 'Windows'
+      #   name: Run Windows tests
+      #   uses: ./.github/actions/test-windows
+      #   with:
+      #     node: ${{ matrix.node }}
 
       - if: runner.os == 'macOS' || runner.os == 'Linux'
-        name: "Run macOS|Linux tests"
+        name: "Run .net core tests"
         run: node tools/test.js CI
         env:
           EDGE_USE_CORECLR: 1