Patch nan in Top-Level node_modules Directory

[gdavidkov]

This pull request includes a modification to the tools/updatenan.js script to improve its reliability on different platforms. The key change is the addition of a check to ensure the correct path to the nan.h file is used, depending on its existence.

Improvements to script reliability:

• tools/updatenan.js: Added existsSync to check for the existence of the nan.h file and adjusted the path accordingly for Windows platforms.

[agracio]

Could you explain how nan can end up outside of node_modules, I am missing something?
Oh I see that would happen in a project that has electron-edge-js as dependency.

[agracio]

Please trigger Build All GitHub workflow on your branch. https://github.com/gdavidkov/electron-edge-js/actions/workflows/build-all.yml

[gdavidkov]

Could you explain how nan can end up outside of node_modules, I am missing something? Oh I see that would happen in a project that has electron-edge-js as dependency.

The reason nan can end up outside of electron-edge-js’s node_modules folder is due to dependency hoisting. When multiple packages in a project rely on the same version of nan, package managers like npm or yarn may "hoist" it to the top-level node_modules to prevent duplicate installations.

One potential solution is to fork nan and modify it according to electron-edge-js’s specific requirements. You could then use your custom version as a direct dependency of your project, ensuring it stays compatible with electron-edge-js. This approach allows full control over the version and configuration of nan, and you can update the fork as needed.

[agracio]

Should be released later today

[agracio]

Released