Skip to content

Commit ecb2f6e

Browse files
authored
Merge branch 'master' into dependabot/pip/idna-3.8
2 parents 0bd016b + bff7631 commit ecb2f6e

File tree

9 files changed

+22
-16
lines changed

9 files changed

+22
-16
lines changed

Diff for: CHANGES/5343.bugfix

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed StreamResponse.prepared to return True after EOF is sent -- by :user:`arthurdarcet`.

Diff for: aiohttp/web_response.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def __init__(
121121

122122
@property
123123
def prepared(self) -> bool:
124-
return self._payload_writer is not None
124+
return self._eof_sent or self._payload_writer is not None
125125

126126
@property
127127
def task(self) -> "Optional[asyncio.Task[None]]":

Diff for: requirements/constraints.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ charset-normalizer==3.3.2
4444
# via requests
4545
cherry-picker==2.2.0
4646
# via -r requirements/dev.in
47-
click==8.1.6
47+
click==8.1.7
4848
# via
4949
# cherry-picker
5050
# pip-tools
@@ -260,7 +260,7 @@ trustme==1.1.0 ; platform_machine != "i686"
260260
# -r requirements/test.in
261261
typer==0.12.5
262262
# via python-on-whales
263-
typing-extensions==4.10.0
263+
typing-extensions==4.12.2
264264
# via
265265
# aioredis
266266
# annotated-types

Diff for: requirements/dev.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ charset-normalizer==3.3.2
4444
# via requests
4545
cherry-picker==2.2.0
4646
# via -r requirements/dev.in
47-
click==8.1.6
47+
click==8.1.7
4848
# via
4949
# cherry-picker
5050
# pip-tools
@@ -252,7 +252,7 @@ trustme==1.1.0 ; platform_machine != "i686"
252252
# -r requirements/test.in
253253
typer==0.12.5
254254
# via python-on-whales
255-
typing-extensions==4.10.0
255+
typing-extensions==4.12.2
256256
# via
257257
# aioredis
258258
# annotated-types

Diff for: requirements/doc-spelling.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ certifi==2024.7.4
1616
# via requests
1717
charset-normalizer==3.3.2
1818
# via requests
19-
click==8.1.6
19+
click==8.1.7
2020
# via towncrier
2121
docutils==0.20.1
2222
# via sphinx

Diff for: requirements/doc.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ certifi==2024.7.4
1616
# via requests
1717
charset-normalizer==3.3.2
1818
# via requests
19-
click==8.1.6
19+
click==8.1.7
2020
# via towncrier
2121
docutils==0.20.1
2222
# via sphinx

Diff for: requirements/lint.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ cfgv==3.4.0
2222
# via pre-commit
2323
charset-normalizer==3.3.2
2424
# via requests
25-
click==8.1.6
25+
click==8.1.7
2626
# via
2727
# slotscheck
2828
# typer
@@ -107,7 +107,7 @@ trustme==1.1.0
107107
# via -r requirements/lint.in
108108
typer==0.12.5
109109
# via python-on-whales
110-
typing-extensions==4.10.0
110+
typing-extensions==4.12.2
111111
# via
112112
# aioredis
113113
# annotated-types

Diff for: requirements/test.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ cffi==1.17.0
2424
# pycares
2525
charset-normalizer==3.3.2
2626
# via requests
27-
click==8.1.6
27+
click==8.1.7
2828
# via
2929
# typer
3030
# wait-for-it
@@ -119,7 +119,7 @@ trustme==1.1.0 ; platform_machine != "i686"
119119
# via -r requirements/test.in
120120
typer==0.12.5
121121
# via python-on-whales
122-
typing-extensions==4.10.0
122+
typing-extensions==4.12.2
123123
# via
124124
# annotated-types
125125
# mypy

Diff for: tests/test_web_response.py

+10-5
Original file line numberDiff line numberDiff line change
@@ -734,11 +734,8 @@ async def test___repr___after_eof() -> None:
734734
resp = StreamResponse()
735735
await resp.prepare(make_request("GET", "/"))
736736

737-
assert resp.prepared
738-
739737
await resp.write(b"data")
740738
await resp.write_eof()
741-
assert not resp.prepared
742739
resp_repr = repr(resp)
743740
assert resp_repr == "<StreamResponse OK eof>"
744741

@@ -1110,14 +1107,22 @@ def test_content_type_with_set_body() -> None:
11101107
assert resp.content_type == "application/octet-stream"
11111108

11121109

1113-
def test_started_when_not_started() -> None:
1110+
def test_prepared_when_not_started() -> None:
11141111
resp = StreamResponse()
11151112
assert not resp.prepared
11161113

11171114

1118-
async def test_started_when_started() -> None:
1115+
async def test_prepared_when_started() -> None:
1116+
resp = StreamResponse()
1117+
await resp.prepare(make_request("GET", "/"))
1118+
assert resp.prepared
1119+
1120+
1121+
async def test_prepared_after_eof() -> None:
11191122
resp = StreamResponse()
11201123
await resp.prepare(make_request("GET", "/"))
1124+
await resp.write(b"data")
1125+
await resp.write_eof()
11211126
assert resp.prepared
11221127

11231128

0 commit comments

Comments
 (0)