File tree 9 files changed +22
-16
lines changed
9 files changed +22
-16
lines changed Original file line number Diff line number Diff line change
1
+ Fixed StreamResponse.prepared to return True after EOF is sent -- by :user:`arthurdarcet`.
Original file line number Diff line number Diff line change @@ -121,7 +121,7 @@ def __init__(
121
121
122
122
@property
123
123
def prepared (self ) -> bool :
124
- return self ._payload_writer is not None
124
+ return self ._eof_sent or self . _payload_writer is not None
125
125
126
126
@property
127
127
def task (self ) -> "Optional[asyncio.Task[None]]" :
Original file line number Diff line number Diff line change @@ -44,7 +44,7 @@ charset-normalizer==3.3.2
44
44
# via requests
45
45
cherry-picker==2.2.0
46
46
# via -r requirements/dev.in
47
- click==8.1.6
47
+ click==8.1.7
48
48
# via
49
49
# cherry-picker
50
50
# pip-tools
@@ -260,7 +260,7 @@ trustme==1.1.0 ; platform_machine != "i686"
260
260
# -r requirements/test.in
261
261
typer==0.12.5
262
262
# via python-on-whales
263
- typing-extensions==4.10.0
263
+ typing-extensions==4.12.2
264
264
# via
265
265
# aioredis
266
266
# annotated-types
Original file line number Diff line number Diff line change @@ -44,7 +44,7 @@ charset-normalizer==3.3.2
44
44
# via requests
45
45
cherry-picker==2.2.0
46
46
# via -r requirements/dev.in
47
- click==8.1.6
47
+ click==8.1.7
48
48
# via
49
49
# cherry-picker
50
50
# pip-tools
@@ -252,7 +252,7 @@ trustme==1.1.0 ; platform_machine != "i686"
252
252
# -r requirements/test.in
253
253
typer==0.12.5
254
254
# via python-on-whales
255
- typing-extensions==4.10.0
255
+ typing-extensions==4.12.2
256
256
# via
257
257
# aioredis
258
258
# annotated-types
Original file line number Diff line number Diff line change @@ -16,7 +16,7 @@ certifi==2024.7.4
16
16
# via requests
17
17
charset-normalizer==3.3.2
18
18
# via requests
19
- click==8.1.6
19
+ click==8.1.7
20
20
# via towncrier
21
21
docutils==0.20.1
22
22
# via sphinx
Original file line number Diff line number Diff line change @@ -16,7 +16,7 @@ certifi==2024.7.4
16
16
# via requests
17
17
charset-normalizer==3.3.2
18
18
# via requests
19
- click==8.1.6
19
+ click==8.1.7
20
20
# via towncrier
21
21
docutils==0.20.1
22
22
# via sphinx
Original file line number Diff line number Diff line change @@ -22,7 +22,7 @@ cfgv==3.4.0
22
22
# via pre-commit
23
23
charset-normalizer==3.3.2
24
24
# via requests
25
- click==8.1.6
25
+ click==8.1.7
26
26
# via
27
27
# slotscheck
28
28
# typer
@@ -107,7 +107,7 @@ trustme==1.1.0
107
107
# via -r requirements/lint.in
108
108
typer==0.12.5
109
109
# via python-on-whales
110
- typing-extensions==4.10.0
110
+ typing-extensions==4.12.2
111
111
# via
112
112
# aioredis
113
113
# annotated-types
Original file line number Diff line number Diff line change @@ -24,7 +24,7 @@ cffi==1.17.0
24
24
# pycares
25
25
charset-normalizer==3.3.2
26
26
# via requests
27
- click==8.1.6
27
+ click==8.1.7
28
28
# via
29
29
# typer
30
30
# wait-for-it
@@ -119,7 +119,7 @@ trustme==1.1.0 ; platform_machine != "i686"
119
119
# via -r requirements/test.in
120
120
typer==0.12.5
121
121
# via python-on-whales
122
- typing-extensions==4.10.0
122
+ typing-extensions==4.12.2
123
123
# via
124
124
# annotated-types
125
125
# mypy
Original file line number Diff line number Diff line change @@ -734,11 +734,8 @@ async def test___repr___after_eof() -> None:
734
734
resp = StreamResponse ()
735
735
await resp .prepare (make_request ("GET" , "/" ))
736
736
737
- assert resp .prepared
738
-
739
737
await resp .write (b"data" )
740
738
await resp .write_eof ()
741
- assert not resp .prepared
742
739
resp_repr = repr (resp )
743
740
assert resp_repr == "<StreamResponse OK eof>"
744
741
@@ -1110,14 +1107,22 @@ def test_content_type_with_set_body() -> None:
1110
1107
assert resp .content_type == "application/octet-stream"
1111
1108
1112
1109
1113
- def test_started_when_not_started () -> None :
1110
+ def test_prepared_when_not_started () -> None :
1114
1111
resp = StreamResponse ()
1115
1112
assert not resp .prepared
1116
1113
1117
1114
1118
- async def test_started_when_started () -> None :
1115
+ async def test_prepared_when_started () -> None :
1116
+ resp = StreamResponse ()
1117
+ await resp .prepare (make_request ("GET" , "/" ))
1118
+ assert resp .prepared
1119
+
1120
+
1121
+ async def test_prepared_after_eof () -> None :
1119
1122
resp = StreamResponse ()
1120
1123
await resp .prepare (make_request ("GET" , "/" ))
1124
+ await resp .write (b"data" )
1125
+ await resp .write_eof ()
1121
1126
assert resp .prepared
1122
1127
1123
1128
You can’t perform that action at this time.
0 commit comments