Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test when symlink encountered #10447

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

Dreamsorcerer
Copy link
Member

Fixes #10436.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Feb 10, 2025
Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #10447 will degrade performances by 25.97%

Comparing Dreamsorcerer-patch-1 (a4ca7ce) with master (289259d)

Summary

❌ 2 (👁 2) regressions
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_one_hundred_get_requests_iter_chunks_on_512kib_chunked_payload[pyloop] 96.8 ms 130.7 ms -25.97%
👁 test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop] 166.1 ms 188.6 ms -11.91%

@bdraco
Copy link
Member

bdraco commented Feb 10, 2025

I think the codspeed might be a caching issue with Python version 3.13.2 vs older? We could pin to 3.13.2 to make it go away or it will on its own

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (289259d) to head (a4ca7ce).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10447      +/-   ##
==========================================
- Coverage   98.76%   98.76%   -0.01%     
==========================================
  Files         122      122              
  Lines       37142    37142              
  Branches     2046     2046              
==========================================
- Hits        36685    36682       -3     
- Misses        317      320       +3     
  Partials      140      140              
Flag Coverage Δ
CI-GHA 98.65% <100.00%> (-0.01%) ⬇️
OS-Linux 98.33% <100.00%> (-0.01%) ⬇️
OS-Windows 96.25% <100.00%> (-0.01%) ⬇️
OS-macOS 97.46% <100.00%> (ø)
Py-3.10.11 97.34% <100.00%> (-0.01%) ⬇️
Py-3.10.16 97.91% <100.00%> (ø)
Py-3.11.11 97.99% <100.00%> (ø)
Py-3.11.9 97.42% <100.00%> (ø)
Py-3.12.8 98.43% <100.00%> (ø)
Py-3.13.1 98.41% <100.00%> (ø)
Py-3.9.13 97.23% <100.00%> (-0.01%) ⬇️
Py-3.9.21 97.79% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.37% <100.00%> (-0.01%) ⬇️
VM-macos 97.46% <100.00%> (ø)
VM-ubuntu 98.33% <100.00%> (-0.01%) ⬇️
VM-windows 96.25% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 343c632 into master Feb 11, 2025
43 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-1 branch February 11, 2025 00:11
Copy link
Contributor

patchback bot commented Feb 11, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/343c632d2a6626c0c46aec588ab50c373550c5c4/pr-10447

Backported as #10448

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 11, 2025
Copy link
Contributor

patchback bot commented Feb 11, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/343c632d2a6626c0c46aec588ab50c373550c5c4/pr-10447

Backported as #10449

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 11, 2025
Dreamsorcerer added a commit that referenced this pull request Feb 11, 2025
…#10449)

**This is a backport of PR #10447 as merged into master
(343c632).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Feb 11, 2025
…#10448)

**This is a backport of PR #10447 as merged into master
(343c632).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_add_static_path_resolution failure with /tmp and /private/tmp
2 participants