Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for conflict between dask array and np.where #144

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Jan 3, 2024

When dask import, use dask.array.where instead of np.where. This should resolve #143 and #122. The solution was originally suggested by @lfery and I extended it to consider the has_dask indicator (True when dask imported, and False for the opposite).

@lee1043
Copy link
Contributor Author

lee1043 commented Jan 3, 2024

@ajdawson I wonder if this fix could be merged to the main and you could release updated version, e.g., v1.4.1. If so, that would be a huge help for my workflow. Because otherwise, I have to consider hosting the capability of eofs in my package directly instead of leveraging on your package that has been considered as one of major dependencies of my package.

@ajdawson ajdawson merged commit 2d509e7 into ajdawson:main Jan 10, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing value location error from projectField
2 participants