Exact path matching command line option #980
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that it comes to shell integration I don't think I am qualified to progress any further, I do hope this will be somewhat useful if anyone has similar ideas. The added feature is |
|
Your git history is whack since you merged instead of rebasing |
SeeStarz
force-pushed
the
exact-match
branch
from
90baa4b to
2e7b1d7
Compare
|
I completely missed that, thanks! |
SeeStarz
changed the title
oriongonza
reviewed
Feb 25, 2025
| @@ -180,6 +180,10 @@ pub struct Query { | |||
| /// Exclude the current directory | |||
| #[clap(long, value_hint = ValueHint::DirPath, value_name = "path")] | |||
| pub exclude: Option<String>, | |||
|
|
|||
| /// Only match exact | |||
There was a problem hiding this comment.
I'd spend a bit more time explaining this feature. This is what will show up in --help
| }); | ||
|
|
||
| if let Some(idx) = idx { | ||
| components = components.drain(0..idx).collect(); |
There was a problem hiding this comment.
This... is convoluted to say the least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept feature improvement related to #260
This adds a new option to allow exact matching of sub path (the ones in between slashes). e.g.
zoxide query rustmatchesrustbut notrust-analyzer. However I haven't been able to understand how to integrate this option into CLI options, as such this pull request isn't complete yet.I personally think just being able to exact match directories would help with QoL especially since the ones most vulnerable to regex matching is short names anyways.
Any feedback would be welcome!