final cleanup of TODO and fixme (#530)

Co-authored-by: Ian Harvey <iharvey@comcast.net>

Author: ith-harvey

src/PoolInfoUtils.sol

@@ -246,7 +246,6 @@ contract PoolInfoUtils {
     /**
      *  @notice Returns the proportion of interest rate which is awarded to lenders;
      *          the remainder accumulates in reserves.
-     *          TODO: move in poolUtilizationInfo
     */
     function lenderInterestMargin(address ajnaPool_)
         external

tests/forge/ERC721Pool/ERC721DSTestPlus.sol

@@ -100,7 +100,8 @@ abstract contract ERC721DSTestPlus is DSTestPlus, IERC721PoolEvents {
                     {
                         uint256 fractionOfNftRemaining = lpsAsCollateral % 1e18;
                         assertLt(fractionOfNftRemaining, 1e18);
-                        // TODO: eliminate the 1 wei workaround for rounding error
+                        
+                        // 1 wei workaround due to rounding
                         depositRequired = Maths.wmul(1e18 - fractionOfNftRemaining + 1, price);
                     }
                     deal(_pool.quoteTokenAddress(), lender, depositRequired);

tests/forge/PositionManager.t.sol

@@ -2426,7 +2426,7 @@ contract PositionManagerERC20PoolTest is PositionManagerERC20PoolHelperContract
         _positionManager.tokenURI(1);
 
         address testAddress = makeAddr("testAddress");
-        uint256 mintAmount  = 10000 * 1e18;
+        uint256 mintAmount  = 10_000 * 1e18;
 
         _mintQuoteAndApproveManagerTokens(testAddress, mintAmount);
 
@@ -2465,12 +2465,6 @@ contract PositionManagerERC20PoolTest is PositionManagerERC20PoolHelperContract
         string memory uriString = _positionManager.tokenURI(tokenId);
         // emit log(uriString);
         assertGt(bytes(uriString).length, 0);
-
-        // FIXME: split out uri string from encoding metadata, and parse resulting json object
-        // decode uri string and check attributes
-        // bytes memory data = Base64.decode(uriString);
-        // DecodeTokenURIParams memory decodedURI = abi.decode(data, (DecodeTokenURIParams));
-        // assertEq(decodedURI.name, "Ajna Token #1");
     }
 
 }

tests/forge/RewardsManager.t.sol

@@ -216,7 +216,6 @@ contract RewardsManagerTest is DSTestPlus {
         epochsClaimed_ = new uint256[](numberOfAuctions_);
         uint256 claimEpoch = lastClaimed_; // starting index, not inclusive
 
-        // FIXME: this doesn't work for non starting auction epochs
         for (uint256 i = 0; i < numberOfAuctions_; i++) {
             epochsClaimed_[i] = claimEpoch + 1;
             claimEpoch += 1;
@@ -708,7 +707,6 @@ contract RewardsManagerTest is DSTestPlus {
             reward:            0.298393183929769729 * 1e18,
             updateRatesReward: 0
         });
-        // TODO: check reward amount vs expected from burn
     }
 
     function testMultiPeriodRewardsSingleClaim() external {
@@ -1498,7 +1496,6 @@ contract RewardsManagerTest is DSTestPlus {
         assertGt(_ajnaToken.balanceOf(_updater), 0);
 
         // calculate rewards earned and compare to percentages for updating and claiming
-        // FIXME: can't calculate this for use in updateBucketExchangeRatesAndClaim as current exchange rate hasn't been updated yet 
         uint256 rewardsEarned = _rewardsManager.calculateRewards(tokenIdOne, _poolOne.currentBurnEpoch());
         assertGt(rewardsEarned, 0);