Skip to content

Commit 80e76fb

Browse files
committed
refactor: update build scripts and Docker configuration
- Update npm script names for better clarity: - dev β†’ start:dev - build β†’ build:prod - start β†’ start:prod - lint β†’ valid:lint - Docker improvements: - Remove unused NODE_ENV build arg - Remove redundant .dist copy - Update build and start commands to match new script names - Update README with new npm commands and legacy peer deps - Fix GitHub Actions workflow username context These changes improve build process clarity and Docker configuration efficiency.
1 parent 48edde3 commit 80e76fb

File tree

4 files changed

+14
-16
lines changed

4 files changed

+14
-16
lines changed

β€Ž.github/workflows/Docker-Image-Build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,20 +30,20 @@ jobs:
3030

3131
- name: Login Into Github Container Registry
3232
run: |
33-
docker login --username aknibircse --password ${{ secrets.DOCKER_TOKEN }} ghcr.io
33+
docker login --username ${{ github.actor }} --password ${{ secrets.DOCKER_TOKEN }} ghcr.io
3434
3535
- name: Create & Execute Environment Variables Files
3636
run: chmod +x ./scripts/create-env.sh && ./scripts/create-env.sh
3737

3838
- name: Build Docker Image
3939
env:
40+
NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }}
41+
CLERK_SECRET_KEY: ${{ secrets.CLERK_SECRET_KEY }}
4042
NEXT_PUBLIC_CLERK_SIGN_IN_URL: ${{ secrets.NEXT_PUBLIC_CLERK_SIGN_IN_URL }}
4143
NEXT_PUBLIC_CLERK_SIGN_UP_URL: ${{ secrets.NEXT_PUBLIC_CLERK_SIGN_UP_URL }}
4244
NEXT_PUBLIC_CLERK_AFTER_SIGN_IN_URL: ${{ secrets.NEXT_PUBLIC_CLERK_AFTER_SIGN_IN_URL }}
4345
NEXT_PUBLIC_CLERK_AFTER_SIGN_UP_URL: ${{ secrets.NEXT_PUBLIC_CLERK_AFTER_SIGN_UP_URL }}
4446
MONGODB_URL: ${{ secrets.MONGODB_URL }}
45-
NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }}
46-
CLERK_SECRET_KEY: ${{ secrets.CLERK_SECRET_KEY }}
4747
WEBHOOK_SECRET: ${{ secrets.WEBHOOK_SECRET }}
4848
NEXT_PUBLIC_CLOUDINARY_CLOUD_NAME: ${{ secrets.NEXT_PUBLIC_CLOUDINARY_CLOUD_NAME }}
4949
NEXT_PUBLIC_CLOUDINARY_API_KEY: ${{ secrets.NEXT_PUBLIC_CLOUDINARY_API_KEY }}

β€ŽDockerfile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ FROM node:18-alpine AS builder
44
WORKDIR /app
55

66
# Define Build Arguments
7-
ARG NODE_ENV
87
ARG NEXT_PUBLIC_CLERK_SIGN_IN_URL
98
ARG NEXT_PUBLIC_CLERK_SIGN_UP_URL
109
ARG NEXT_PUBLIC_CLERK_AFTER_SIGN_IN_URL
@@ -54,7 +53,7 @@ RUN npm cache clean --force && \
5453
COPY . .
5554

5655
# PRODUCTION BUILD FOR THIS APP
57-
RUN npm run build
56+
RUN npm run build:prod
5857

5958
# STAGE-2: FINAL DOCKER IMAGE BUILDS FOR THIS APP
6059
FROM node:18-alpine AS runner
@@ -85,7 +84,6 @@ ARG NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY
8584
COPY --from=builder /app/package.json ./package.json
8685
COPY --from=builder /app/package-lock.json ./package-lock.json
8786
COPY --from=builder /app/.next ./.next
88-
COPY --from=builder /app/.next ./.dist
8987
COPY --from=builder /app/public ./public
9088
COPY --from=builder /app/node_modules ./node_modules
9189

@@ -113,4 +111,4 @@ ENV PORT=3000 \
113111
NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY=$NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY
114112

115113
# RUN THIS APP IN PRODUCTION MODE
116-
CMD ["npm", "run", "start"]
114+
CMD ["npm", "run", "start:prod"]

β€ŽREADME.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ cd RUPANTAR_An-AI-Based-SaaS
118118
Install The Project Dependencies Using NPM: *(* *Reuired NodeJS_V.20.9.0_LTS* *)*
119119

120120
```bash
121-
npm install --save-dev
121+
npm install --legacy-peer-deps
122122
```
123123

124124
</br>
@@ -169,30 +169,30 @@ Replace The Placeholder Values with Your Actual Respective Account Credentials.
169169
**Run This Project In Development Mode**
170170

171171
```bash
172-
npm run dev
172+
npm run start:dev
173173
```
174174

175175
</br>
176176

177177
**Build Production Version Of This Project**
178178

179179
```bash
180-
npm run build
180+
npm run build:prod
181181
```
182182

183183
</br>
184184

185185
**Running The Build Version Of This Project**
186186

187187
```bash
188-
npm run start
188+
npm run start:prod
189189
```
190190
<br/>
191191

192192
**Validate ESLint Rule For Errors & Warnings**
193193

194194
```bash
195-
npm run lint
195+
npm run valid:lint
196196
```
197197
</br>
198198

β€Žpackage.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
"version": "_v.02.02.24_--Release",
44
"private": true,
55
"scripts": {
6-
"dev": "next dev",
7-
"build": "next build",
8-
"start": "next start",
9-
"lint": "next lint"
6+
"start:dev": "next dev",
7+
"build:prod": "next build",
8+
"start:prod": "next start",
9+
"valid:lint": "next lint"
1010
},
1111
"dependencies": {
1212
"@clerk/nextjs": "^4.29.6",

0 commit comments

Comments
Β (0)