Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering support for recurring events #379

Merged

Conversation

marcauberer
Copy link
Contributor

Add rendering support for recurring events

@aldabil21
Copy link
Owner

@marcauberer appreciate it
This will bring a lot of other related work, such as: start, end, daysOfWeek etc... or rrule.
I'm not sure if we can go this simple? what do you think

@marcauberer
Copy link
Contributor Author

@aldabil21 Didn't knew rrule, but it looks promising. Yes, maybe this is worth trying. I will prepare an updated pr ...

@marcauberer
Copy link
Contributor Author

@aldabil21 sorry it took so long. I was on vacation. The pr is now updated with rrule support. What do you think?

@marcauberer
Copy link
Contributor Author

@aldabil21 any feedback on this?

@marcauberer
Copy link
Contributor Author

@aldabil21 ping

@majilan37
Copy link

This is really cool, i am waiting for this feature

@aldabil21
Copy link
Owner

Thank you @marcauberer
Currenct caveat is, onDrop must be override by the user to re-create a rrule.

we can go with this for now

@aldabil21 aldabil21 merged commit 88101c3 into aldabil21:master Sep 4, 2024
2 checks passed
@marcauberer marcauberer deleted the feature/rendering-recurring-events branch September 4, 2024 11:39
@marcauberer
Copy link
Contributor Author

@aldabil21 thanks for merging. Will take a look at onDrop soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants