Merge branch 'develop' into devsecops

aleks-ivanov · Aug 8, 2024 · bc4d3f9 · bc4d3f9
2 parents 4ab5adb + 0d9ca79
commit bc4d3f9
Show file tree

Hide file tree

Showing 9 changed files with 209 additions and 67 deletions.
diff --git a/...itext.sign.tests/itext/signatures/validation/DocumentRevisionsValidatorIntegrationTest.cs b/...itext.sign.tests/itext/signatures/validation/DocumentRevisionsValidatorIntegrationTest.cs
@@ -470,6 +470,28 @@ public virtual void TaggedDocRemoveStructTreeElementTest(bool continueValidation
             }
         }
 
+        [NUnit.Framework.TestCaseSource("CreateParameters")]
+        public virtual void OutlinesNotModifiedTest(bool continueValidationAfterFail) {
+            SetUp(continueValidationAfterFail);
+            using (PdfDocument document = new PdfDocument(new PdfReader(SOURCE_FOLDER + "outlinesNotModified.pdf"))) {
+                DocumentRevisionsValidator validator = builder.BuildDocumentRevisionsValidator();
+                ValidationReport report = validator.ValidateAllDocumentRevisions(validationContext, document);
+                AssertValidationReport.AssertThat(report, (a) => a.HasStatus(ValidationReport.ValidationResult.VALID));
+            }
+        }
+
+        [NUnit.Framework.TestCaseSource("CreateParameters")]
+        public virtual void OutlinesModifiedTest(bool continueValidationAfterFail) {
+            SetUp(continueValidationAfterFail);
+            using (PdfDocument document = new PdfDocument(new PdfReader(SOURCE_FOLDER + "outlinesModified.pdf"))) {
+                DocumentRevisionsValidator validator = builder.BuildDocumentRevisionsValidator();
+                ValidationReport report = validator.ValidateAllDocumentRevisions(validationContext, document);
+                AssertValidationReport.AssertThat(report, (a) => a.HasStatus(ValidationReport.ValidationResult.INVALID).HasNumberOfFailures
+                    (1).HasLogItem((l) => l.WithCheckName(DocumentRevisionsValidator.DOC_MDP_CHECK).WithMessage(DocumentRevisionsValidator
+                    .NOT_ALLOWED_CATALOG_CHANGES).WithStatus(ReportItem.ReportItemStatus.INVALID)));
+            }
+        }
+
         [NUnit.Framework.TestCaseSource("CreateParameters")]
         public virtual void TaggedDocRemoveStructTreeAnnotationTest(bool continueValidationAfterFail) {
             SetUp(continueValidationAfterFail);

diff --git a/itext.tests/itext.sign.tests/itext/signatures/validation/DocumentRevisionsValidatorTest.cs b/itext.tests/itext.sign.tests/itext/signatures/validation/DocumentRevisionsValidatorTest.cs
@@ -505,6 +505,63 @@ public virtual void ModifyPageAnnotsTest(bool continueValidationAfterFail) {
             }
         }
 
+        [NUnit.Framework.TestCaseSource("CreateParameters")]
+        public virtual void GotoReferencesModifiedStructTreeElemTest(bool continueValidationAfterFail) {
+            SetUp(continueValidationAfterFail);
+            using (PdfDocument document = new PdfDocument(new PdfReader(SOURCE_FOLDER + "gotoReferencesModifiedStructTreeElem.pdf"
+                ))) {
+                DocumentRevisionsValidator validator = builder.BuildDocumentRevisionsValidator();
+                validator.SetAccessPermissions(AccessPermissions.FORM_FIELDS_MODIFICATION);
+                PdfRevisionsReader revisionsReader = new PdfRevisionsReader(document.GetReader());
+                IList<DocumentRevision> documentRevisions = revisionsReader.GetAllRevisions();
+                ValidationReport validationReport = new ValidationReport();
+                validator.ValidateRevision(documentRevisions[documentRevisions.Count - 2], documentRevisions[documentRevisions
+                    .Count - 1], document, validationReport, validationContext);
+                AssertValidationReport.AssertThat(validationReport, (a) => a.HasStatus(ValidationReport.ValidationResult.VALID
+                    ));
+            }
+        }
+
+        [NUnit.Framework.TestCaseSource("CreateParameters")]
+        public virtual void CatalogReferenceInRandomPlaceTest(bool continueValidationAfterFail) {
+            SetUp(continueValidationAfterFail);
+            using (PdfDocument document = new PdfDocument(new PdfReader(SOURCE_FOLDER + "catalogReferenceInRandomPlace.pdf"
+                ))) {
+                DocumentRevisionsValidator validator = builder.BuildDocumentRevisionsValidator();
+                validator.SetAccessPermissions(AccessPermissions.FORM_FIELDS_MODIFICATION);
+                PdfRevisionsReader revisionsReader = new PdfRevisionsReader(document.GetReader());
+                IList<DocumentRevision> documentRevisions = revisionsReader.GetAllRevisions();
+                ValidationReport validationReport = new ValidationReport();
+                validator.ValidateRevision(documentRevisions[documentRevisions.Count - 2], documentRevisions[documentRevisions
+                    .Count - 1], document, validationReport, validationContext);
+                AssertValidationReport.AssertThat(validationReport, (a) => a.HasStatus(ValidationReport.ValidationResult.VALID
+                    ));
+                validator.ValidateRevision(documentRevisions[documentRevisions.Count - 3], documentRevisions[documentRevisions
+                    .Count - 2], document, validationReport, validationContext);
+                AssertValidationReport.AssertThat(validationReport, (a) => a.HasStatus(ValidationReport.ValidationResult.VALID
+                    ));
+            }
+        }
+
+        [NUnit.Framework.TestCaseSource("CreateParameters")]
+        public virtual void CatalogReferenceInRandomPlaceModifiedTest(bool continueValidationAfterFail) {
+            SetUp(continueValidationAfterFail);
+            using (PdfDocument document = new PdfDocument(new PdfReader(SOURCE_FOLDER + "catalogReferenceInRandomPlaceModified.pdf"
+                ))) {
+                DocumentRevisionsValidator validator = builder.BuildDocumentRevisionsValidator();
+                validator.SetAccessPermissions(AccessPermissions.FORM_FIELDS_MODIFICATION);
+                PdfRevisionsReader revisionsReader = new PdfRevisionsReader(document.GetReader());
+                IList<DocumentRevision> documentRevisions = revisionsReader.GetAllRevisions();
+                ValidationReport validationReport = new ValidationReport();
+                validator.ValidateRevision(documentRevisions[documentRevisions.Count - 2], documentRevisions[documentRevisions
+                    .Count - 1], document, validationReport, validationContext);
+                AssertValidationReport.AssertThat(validationReport, (a) => a.HasStatus(ValidationReport.ValidationResult.INVALID
+                    ).HasNumberOfFailures(1).HasNumberOfLogs(1).HasLogItem((l) => l.WithCheckName(DocumentRevisionsValidator
+                    .DOC_MDP_CHECK).WithMessage(DocumentRevisionsValidator.PAGE_MODIFIED).WithStatus(ReportItem.ReportItemStatus
+                    .INVALID)));
+            }
+        }
+
         [NUnit.Framework.TestCaseSource("CreateParameters")]
         public virtual void MultipleRevisionsDocumentLevel3Test(bool continueValidationAfterFail) {
             SetUp(continueValidationAfterFail);

diff --git a/...text/signatures/validation/DocumentRevisionsValidatorIntegrationTest/outlinesModified.pdf b/...text/signatures/validation/DocumentRevisionsValidatorIntegrationTest/outlinesModified.pdf
diff --git a/...t/signatures/validation/DocumentRevisionsValidatorIntegrationTest/outlinesNotModified.pdf b/...t/signatures/validation/DocumentRevisionsValidatorIntegrationTest/outlinesNotModified.pdf
diff --git a/...xt/signatures/validation/DocumentRevisionsValidatorTest/catalogReferenceInRandomPlace.pdf b/...xt/signatures/validation/DocumentRevisionsValidatorTest/catalogReferenceInRandomPlace.pdf
diff --git a/...tures/validation/DocumentRevisionsValidatorTest/catalogReferenceInRandomPlaceModified.pdf b/...tures/validation/DocumentRevisionsValidatorTest/catalogReferenceInRandomPlaceModified.pdf
diff --git a/...atures/validation/DocumentRevisionsValidatorTest/gotoReferencesModifiedStructTreeElem.pdf b/...atures/validation/DocumentRevisionsValidatorTest/gotoReferencesModifiedStructTreeElem.pdf