Skip to content

Commit 3da8ca1

Browse files
committed
update credits
1 parent 573a8fe commit 3da8ca1

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

credits.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@
5656

5757
* Wrote PS1 Packer and released it as an easy to use [submodule](https://github.com/pcsx-redux/support). Helped implement it for the memory card boot methods.
5858

59+
* Corrected the CD_REGS value in `loader/cdrom.c` to use the right memory region.
60+
61+
* Came up with the best `cdrom:\\` text stripper for `CdGetLbn()` in `loader/secondary.c`
62+
5963
## Misc Acknowledgements
6064

6165
* [Berion](https://www.psx-place.com/members/berion.1431/) of [PSX-Place](https://psx-place.com) compressed the images of this document properly (this is the first time I've edited photos).

loader/secondary.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,7 @@ void try_boot_cd() {
700700
debug_write("Reading executable header");
701701

702702
if(bios_is_ps1() == false) {
703-
// CdGetLbn() needs any cdrom:\\, cdrom:\, or cdrom: in the bootfile string from SYSTEM.CNF to be stripped out
703+
// CdGetLbn() needs any cdrom:\\, cdrom:\, or cdrom: in the bootfile string from SYSTEM.CNF to be stripped out. The function below is by Nicholas Noble
704704
char * bootfile_for_CdGetLbn = 0;
705705
uint32_t hash = 5381;
706706
for (unsigned i = 0; i < 8; i++) {
@@ -756,7 +756,7 @@ void try_boot_cd() {
756756

757757
/*
758758
759-
See https://github.com/grumpycoders/pcsx-redux/blob/a072e38d78c12a4ce1dadf951d9cdfd7ea59220b/src/mips/openbios/main/main.c#L380-L381 for the OpenBIOS equivelent line of bugged code we are working around! Thanks Nicholas Noble
759+
See https://github.com/grumpycoders/pcsx-redux/blob/a072e38d78c12a4ce1dadf951d9cdfd7ea59220b/src/mips/openbios/main/main.c#L380-L381 for the OpenBIOS equivelent line of bugged code we are working around, found by Nicholas Noble
760760
761761
King's Field Japan (SLPS_00017) is a very early PSX.EXE Japan game. While the PSX.EXE is having 0x34/0x38 contain SP values, these are apparently garbage and not being used in reality by a real BIOS boot. These ARE being used by both our exec calls below however so we need to zero out that garbage so it is not used, which finally allows King's Feild (and most likely other PSX.EXE games) to boot correctly.
762762

0 commit comments

Comments
 (0)