move chdir to next step

Author: alexravenna

src/converter.ts

@@ -1,16 +1,26 @@
-import { getInput, setFailed } from "@actions/core";
+import * as core from "@actions/core";
 import { exec } from "@actions/exec";
+import path from "path";
 
 /**
  * Converts the given VS Code theme to a Visual Studio theme.
  * @param dir
  */
-export async function convertTheme(dir: string): Promise<void> {
-    const themeToConvert = getInput("path");
+export async function convertTheme(
+    workDir: string,
+    themePath: string,
+): Promise<void> {
+    const themeDir = path.resolve(themePath);
+    core.info(`Converting theme ${themeDir}...`);
 
     try {
-        exec(`bin\Debug\net6.0\ThemeConverter.exe`, [`-i ${themeToConvert}`]);
+        // ThemeConverter looks for some files in the same directory as the executable relatively,
+        // so we have to execute it there and not from the action root
+        process.chdir(
+            `${core.toPlatformPath(`${workDir}/ThemeConverter/ThemeConverter/bin/Debug/net6.0`)}`,
+        );
+        await exec(`./ThemeConverter -i ${themeDir}`);
     } catch (error: any) {
-        setFailed(`Action failed with error: "${error.message}"`);
+        core.setFailed(`Action failed with error: "${error.message}"`);
     }
 }

src/main.ts

@@ -15,7 +15,8 @@ export async function run(): Promise<void> {
 
         // Clone and build ThemeConverter program
         await cloneRepository(WORK_DIRECTORY);
-        await buildProject(WORK_DIRECTORY);
+        const projectDir = await buildProject(WORK_DIRECTORY);
+        if (projectDir === undefined) throw new Error();
 
         // Convert theme JSON
         const path = core.getInput("path");
@@ -24,6 +25,6 @@ export async function run(): Promise<void> {
         core.setOutput("output-vsix", "");
     } catch (error) {
         // Fail the workflow run if an error occurs
-        if (error instanceof Error) core.setFailed(error.message);
+        if (error instanceof Error) core.setFailed(error);
     }
 }

src/themeConverter.ts

@@ -1,4 +1,4 @@
-import { exec,  } from "@actions/exec";
+import { exec } from "@actions/exec";
 import { toPlatformPath, setFailed, info } from "@actions/core";
 
 /**
@@ -28,8 +28,9 @@ export async function buildProject(buildDir: string): Promise<void> {
     info(`Building ThemeConverter project in "${buildDir}"...`);
 
     try {
-        process.chdir(`${toPlatformPath(`${buildDir}/ThemeConverter/ThemeConverter/`)}`);
-        await exec(`dotnet build ThemeConverter.csproj`);
+        await exec(
+            `dotnet build ${toPlatformPath(`${buildDir}/ThemeConverter/ThemeConverter/ThemeConverter.csproj`)}`,
+        );
     } catch (error) {
         setFailed(`Action failed with error: "${(error as Error).message}"`);
     }